#1509: ExternalLibraries do not check if patch is available --------------------------------------------+------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: LORENE hwloc ExternalLibraries | --------------------------------------------+------------------------------- some of the ExternalLibraries (LORENE, hwloc for example) use patch to modify the upstream source. However they do not check if patch is available and blindly use the flesh supplied $PATCH variable.
Since the flesh does not abort its configuration even when patch is missing, this fails with an error message of the form "-p0: command not found".
Either the flesh's configure should require patch to be present, or the ExternalLibraries need to test for PATCH being empty (there is a bash expansion that aborts if PATCH is undefined).
#1509: ExternalLibraries do not check if patch is available ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: LORENE hwloc ExternalLibraries ------------------------------------+---------------------------------------
Comment (by eschnett):
Some thorns use ${PATCH?} instead of $PATCH. I think this is the way to go.
#1509: ExternalLibraries do not check if patch is available ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: LORENE hwloc ExternalLibraries ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
The ExternalLibraries already all use the ${PATCH?} variant. The attached patches add more explicit checks and error messages.
#1509: ExternalLibraries do not check if patch is available ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: LORENE hwloc ExternalLibraries ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply.
#1509: ExternalLibraries do not check if patch is available ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: LORENE hwloc ExternalLibraries ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as rev 44 of BLAS rev 35 of FFTW3 rev 45 of GSL rev 84 of HDF5 rev 46 of LAPACK rev 50 or LORENE rev 41 of MPI.
#1509: ExternalLibraries do not check if patch is available ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: LORENE hwloc ExternalLibraries ------------------------------------+---------------------------------------
Comment (by rhaas):
Also applied as rev 59 of OpenSSL rev 43 of hwloc rev 40 of libjpeg rev 41 of zlib.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit