[Einstein Toolkit] #1171: WeylScal4 schedule order is incorrect

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1221:...

[Einstein Toolkit] #1333: Fortran...

Einstein Toolkit

7 Nov 2012 7 Nov '12

10:12 a.m.

#1171: WeylScal4 schedule order is incorrect -----------------------------------+---------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: WeylScal4 testsuite | -----------------------------------+---------------------------------------- WeylScal4 contains a calculation for computing the I and J invariants from the Psis. This calculation is not scheduled explicitly after the Psis. Therefore, Cactus will probably schedule the routines alphabetically, which should be wrong. This should be corrected either with an After or Schedule element in the calculation.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

15 Nov 15 Nov

10:22 p.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: new => review

Comment:

In addition to correcting the schedule, the enclosed patch also adds a "WeylScal4_" prefix to all schedule items, and evaluates the invariants pointwise instead of applying boundary conditions.

{{{ Index: WeylScal4.m =================================================================== --- WeylScal4.m (revision 124) +++ WeylScal4.m (working copy) @@ -302,7 +302,7 @@

Psi4Calc[fdOrder_, PD_] := { - Name -> "psi4_calc_" <> fdOrder, + Name -> "WeylScal4_psi4_calc_" <> fdOrder, Where -> Interior, After -> "ADMBase_SetADMVars", ConditionalOnKeywords -> {{"fd_order", fdOrder}, {"calc_scalars", "psi4"}}, @@ -312,7 +312,7 @@

PsisCalc[fdOrder_, PD_] := { - Name -> "psis_calc_" <> fdOrder, + Name -> "WeylScal4_psis_calc_" <> fdOrder, Where -> Interior, After -> "ADMBase_SetADMVars", ConditionalOnKeywords -> {{"fd_order", fdOrder}, {"calc_scalars", "psis"}}, @@ -322,9 +322,9 @@

InvariantsCalc[fdOrder_, PD_] := { - Name -> "invars_calc_" <> fdOrder, - Where -> Interior, - After -> "ADMBase_SetADMVars", + Name -> "WeylScal4_invars_calc_" <> fdOrder, + Where -> Everywhere, + After -> "WeylScal4_psis_calc_" <> fdOrder <> "_group", ConditionalOnKeywords -> {{"fd_order", fdOrder}, {"calc_scalars", "psis"}, {"calc_invariants", "always"}}, Equations -> invariantEqs }; }}}

We should also modify one of the test cases to calculate the invariants as well.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

19 Nov 19 Nov

7:46 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite ------------------------------------+--------------------------------------- Changes (by hinder):

* status: review => reviewed_ok

Comment:

Thanks. Looks good! Please apply.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7:58 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite ------------------------------------+---------------------------------------

Comment (by hinder):

#1182 is an enhancement ticket for adding the test cases for the invariants.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:26 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: WeylScal4 testsuite ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Applied.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

30 Jan 30 Jan

1:53 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite backport ------------------------------------+--------------------------------------- Changes (by hinder):

* keywords: WeylScal4 testsuite => WeylScal4 testsuite backport * status: closed => reopened * resolution: fixed =>

Comment:

I think this is a candidate for backporting to the release. My only concern is that computing the invariants pointwise rather than using boundary conditions will change numerical results, and is an enhancement not a fix. Additionally, the change in name of the functions could cause other thorns which rely on these names for scheduling purposes to break. I would backport the fix to the scheduling order only. What do others think?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite backport ------------------------------------+---------------------------------------

Comment (by rhaas):

Can we separate out the bugfix from the ehancement? Ideally we would also not re-release until the tests pass on at least some of the machines (some that are convenient or important I would guess). We don't want to accidentally break the release branch.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:33 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite backport ------------------------------------+---------------------------------------

Comment (by hinder):

I have set up automated tests for the release branch (https://build.barrywardell.net/job/EinsteinToolkitReleased/). These are only run on a single machine (a ubuntu VM), not a production machine. The tests will only be run AFTER we commit to the release branch. And at that point, the code will be downloaded by anyone checking out the released version, as we tell people to check out by branch not by tag. I have moved this discussion to the mailing list, as it affects a wider audience.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8 Apr 8 Apr

10:50 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reopened Priority: major | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite backport ------------------------------------+--------------------------------------- Changes (by eschnett):

* milestone: => ET_2013_05

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12 Apr 12 Apr

6:51 a.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reopened Priority: major | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite backport ------------------------------------+---------------------------------------

Comment (by hinder):

For the upcoming release, we should fix the schedule order only. The pointwise computation and the renaming both break backward compatibility.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6 May 6 May

11:29 p.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reopened Priority: major | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite backport ------------------------------------+---------------------------------------

Comment (by knarf):

Isn't this patch already applied, and thus, also the point-wise calculation? It seems that this bug was only re-opened to get the schedule-change into the 2012_11 release, which by now is kind of pointless. Can this bug be closed again?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10 May 10 May

1:27 p.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite backport ------------------------------------+--------------------------------------- Changes (by knarf):

* status: reopened => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 May 17 May

2:23 p.m.

#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: closed Priority: major | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: WeylScal4 testsuite backport ------------------------------------+--------------------------------------- Changes (by knarf):

* status: review => closed * resolution: => fixed

Comment:

This has been applied already some time ago.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1171#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4893

Age (days ago)

5084

Last active (days ago)

trac@lists.einsteintoolkit.org

12 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit