#1171: WeylScal4 schedule order is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: WeylScal4 testsuite ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
In addition to correcting the schedule, the enclosed patch also adds a "WeylScal4_" prefix to all schedule items, and evaluates the invariants pointwise instead of applying boundary conditions.
{{{ Index: WeylScal4.m =================================================================== --- WeylScal4.m (revision 124) +++ WeylScal4.m (working copy) @@ -302,7 +302,7 @@
Psi4Calc[fdOrder_, PD_] := { - Name -> "psi4_calc_" <> fdOrder, + Name -> "WeylScal4_psi4_calc_" <> fdOrder, Where -> Interior, After -> "ADMBase_SetADMVars", ConditionalOnKeywords -> {{"fd_order", fdOrder}, {"calc_scalars", "psi4"}}, @@ -312,7 +312,7 @@
PsisCalc[fdOrder_, PD_] := { - Name -> "psis_calc_" <> fdOrder, + Name -> "WeylScal4_psis_calc_" <> fdOrder, Where -> Interior, After -> "ADMBase_SetADMVars", ConditionalOnKeywords -> {{"fd_order", fdOrder}, {"calc_scalars", "psis"}}, @@ -322,9 +322,9 @@
InvariantsCalc[fdOrder_, PD_] := { - Name -> "invars_calc_" <> fdOrder, - Where -> Interior, - After -> "ADMBase_SetADMVars", + Name -> "WeylScal4_invars_calc_" <> fdOrder, + Where -> Everywhere, + After -> "WeylScal4_psis_calc_" <> fdOrder <> "_group", ConditionalOnKeywords -> {{"fd_order", fdOrder}, {"calc_scalars", "psis"}, {"calc_invariants", "always"}}, Equations -> invariantEqs }; }}}
We should also modify one of the test cases to calculate the invariants as well.