[Einstein Toolkit] #1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile --------------------+------------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: | --------------------+------------------------------------------------------- this seems to be due to the parameter file structures in {{{ configs/configname/bindings/include/CParameterStructNames.h }}} being regenerated. At least "make -d" lists them as newer as the C source file dependency files. There seems to be only one such file for the whole configuration. My unsubstantiated guess is that this is because CParameterStructNames.h was one of the files that were excluded from dependency tracking prior to #768 (see eg line 182 of lib/make/make.config.defn.in in https://trac.einsteintoolkit.org/attachment/ticket/768/NoThornIs12.patch).
Classified as minor since it is just extra careful, but try adding thorns on kraken to see just how annoying this can be :-)
I will try and see what happens if I reinstate the dependency exclusions, but input of the patch author would be helpful to understand why the exclusions were removed (I assume they should no longer be required).
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => review
Comment:
CParameterStructNames.h seems to be the single file out of the ones that used to be excluded that still needs to be excluded.
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
The content of this file seems boilerplate, and it should be easy enough to split this file into one file per thorn.
The reason why this file exists is likely that it translates between C and Fortran names; C uses structures to store parameters, while Fortran uses common blocks, and the #defines in this file implement the Fortran name mangling scheme. I assume that this file is generated by Perl code, depending on the auto-detected Fortran name mangling scheme.
Of course, re-instating excluding this file will also work just fine, assuming it doesn't break Steve's Eclipse project.
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
Comment:
This problem is veryvery annoing.
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* priority: minor => major
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
Second ok needed since it touches the flesh... Anyone. Please. Try this on hopper if you think this is only minor :-).
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by hinder):
I don't understand the code well enough to give a definitive "OK". If this is only a revert of a previous patch, then please apply, as this is an important issue to fix. If so, please include in the commit message the revision number of the reverted code.
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
It's not a full revert. I only partially reverts the content of a single line of the commit in #768.
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
The original patch removed special treatment for three (or so) files, assuming that these files are not generated any more. This was wrong, and this patch reverts special treatment for one of these files.
#1004: adding or removing thorns to a thorn list triggers what seems to be a full recompile ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
I treat Ian's comment as the second "please apply".
trac@lists.einsteintoolkit.org
-
Einstein Toolkit