#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: | ----------------------+----------------------------------------------------- It should.
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: new => review
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: hinder Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by hinder):
* owner: => hinder
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: hinder Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by hinder):
This patch does not apply cleanly. It looks like parts of it might have already been applied, and those parts look unrelated to the advertised feature of this ticket.
MacBook-2:flesh (trunk) $ patch -p0 < ~/Downloads/gfindex.diff patching file src/include/cctk.h Hunk #1 FAILED at 175. Hunk #3 FAILED at 349. Hunk #6 FAILED at 424. 3 out of 6 hunks FAILED -- saving rejects to file src/include/cctk.h.rej patching file src/main/DebugDefines.c Reversed (or previously applied) patch detected! Assume -R? [n] ^C
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: hinder Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by eschnett):
Do you have any comments on the content of the patch?
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: hinder Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by eschnett):
I attach a new version of this patch.
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: hinder Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by hinder):
The patch looks to be correct, and should be very useful if people know about using the DEBUG option. Most people probably think, as I did, that it enables debugging symbols. In fact, the simfactory documentation on the "--debug" option states this.
I have tested (on my laptop) that the ML_BSSN_sgw3d_rhs test still passes both with and without DEBUG=yes (via simfactory --debug), and that if I manually edit the code in McLachlan to loop outside the range with --debug, I get the required error.
The patch uses cctk_lsh. Should it use cctk_lssh instead, to be compatible with future padding features? I don't remember the details of that.
Please apply.
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: hinder Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by eschnett):
I took the index checking code from the file DebugDefines.c, which is used if CCTK_DEBUG is set and if inlining is not supported.
#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: hinder Type: defect | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit