#513: Make signbit in Vectors work on more architectures -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- Several C++ compilers cannot handle std::signbit. There is also a namespace problem when using the same identifier Vectors_SGN for different precisions (real*4 and real*8). In addition, kifpos is implemented incorrectly on several architectures. The attached patch corrects these.
#513: Make signbit in Vectors work on more architectures ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#513: Make signbit in Vectors work on more architectures ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
The changes look good to me. I've tested the SSE and default versions and they all compile and pass the Vectors testsuite on Damiana, Datura and my laptop. They also compile on Scientific Linux 6 which previously caused problems for me.
I didn't test the Altivec, DoubleHummer or VSX changes but they look correct. Any errors should be caught by the testsuites, so assuming those pass, I think this should be be committed.
#513: Make signbit in Vectors work on more architectures ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit