#1410: add boost external library to ET -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: new Priority: major | Milestone: Component: Carpet | Version: development version Keywords: Boost | -------------------------+-------------------------------------------------- David Radice provided a thorn for Boost (www.boost.org) in 2011 (http://lists.einsteintoolkit.org/pipermail/users/2011-July/001219.html). CarpetLib can use it for its bboxset2 class if the C++ STL does not support all of C++11.
It would thus be nice to include it in the ET. The thorn repo is on github: https://github.com/dradice/Boost
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: Boost --------------------------+------------------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
Thorn to be reviewed is on github
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: Boost --------------------------+-------------------------------------------------
Comment (by eschnett):
Boost is a high quality library that extends and anticipates C++ language development. It is very useful for many C++ projects.
On the other hand, Boost is a very large library, and takes a long time to build.
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: Boost --------------------------+-------------------------------------------------
Comment (by rhaas):
In that case: how about including only donwload instructions in the ET thornlist so that users can uncomment them when Boost is needed. ie:
{{{ # Boost library !TARGET = $ARR !TYPE = git !AUTH_URL = git@github.com:dradice/Boost.git !URL = git://github.com/dradice/Boost.git !REPO_PATH = ../$2 !CHECKOUT = #ExternalLibraries/Boost }}}
It does take a while to compile. For some reason it also does not pick up a -j option which I think the other ExternalLibraries see (or do they?).
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: Boost --------------------------+-------------------------------------------------
Comment (by eschnett):
This is a good idea. We do the same already for OpenCL, and there are a few other libraries or thorns that are similarly interesting, such as e.g. PETSc. Removing comments from a thorn list is one way, but we could introduce a better way as well.
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: Boost --------------------------+------------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied as rev 342 of manifest.
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: Boost --------------------------+-------------------------------------------------
Comment (by knarf):
Even though it is commented out, and even though I don't have any objections myself, we should follow our own procedure and vote on inclusion into the toolkit. Even if it is commented out everything mentioned in the thornlist is part of it.
I propose _not_ reverting the change again, and vote after-the-fact next Monday, expecting a positive result.
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: Boost --------------------------+-------------------------------------------------
Comment (by rhaas):
ok.
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: Boost --------------------------+-------------------------------------------------
Comment (by hinder):
It's not commented out; it broke the build, as the thorn is not in the super-repository. Please comment it out!
I would also like to propose that we discourage people from using this library. It takes 1 GB of space just for the source files, and a long time to compile, and we don't want to have to go through this pain on slow, space-limited HPC systems if we can avoid it. Would it be possible to just extract the bits that are needed?
#1410: add boost external library to ET --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: Boost --------------------------+-------------------------------------------------
Comment (by rhaas):
I commented it out now. Very sorry. To tell the truth I had originally mixed up the please apply for the PUGH patch for aligned data with Boost but then since it was (supposedly) commented out did not think about it anymore. I would not recommend this to be build by default. I would also try and move it into a subversion repository so that only the current version makes it onto the users disk and not the full history. This would reduce file size (dist is 67MB which is still twice as large as the biggest ExternalLibrary so far [MPI] but at least no longer by an order of magnitude, .git is 406MB) but obviously not help with build time.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit