[Einstein Toolkit] #1504: MoL RK87 non-functional

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1367: Mojave...

[Einstein Toolkit] #1492: missing...

Einstein Toolkit

13 Dec 2013 13 Dec '13

12:32 p.m.

#1504: MoL RK87 non-functional -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: MoL | -----------------------------------+---------------------------------------- currently (Noether release and trunk, since rev 190) MoL's RK87.c file contains a line (line 234): {{{ CCTK_WARN(0, "Peter has been too lazy to write the RK87 routine " "out for array variables. Better send him an email..."); }}} which unconditionally aborts the run whenever RK87 is used, even when used for grid functions and not grid arrays. The fix is obviously to check MoLNumEvolvedArrayVariables before aborting: {{{ if (MoLNumEvolvedArrayVariables > 0 || MoLNumEvolvedComplexArrayVariables > 0) { CCTK_WARN(0, "Peter has been too lazy to write the RK87 routine " "out for array variables. Better send him an email..."); } }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

13 Dec 13 Dec

12:33 p.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:47 p.m.

Comment (by sbrandt):

This is hilarious.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:52 p.m.

Comment (by knarf):

It is. However, it is sad that this was not triggered by a testsuite, which quite clearly means that there is no testsuite that uses RK78. Please backport that proposed change to the release (after testing it, obviously).

After that, we should think about an easy way to test all methods currently implemented in MoL - one short and small, but yet meaningful testsuite for each of them. What about using the testsuite of CactusExamples/WaveMoL as template?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:59 p.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: review => reviewed_ok

Comment:

Yes, I think the lesson to learn from this is to make sure we have better test coverage. The RK87 method is apparently used, I suspect because it is a variable timestep method and variable timesteps are only useful with PUGH. This actually worked before and we missed the regression in the review :-).

Did we already agree on a way to tag fixes for backporting? Using "Please backport" in the ticket? Adding a "Backport" keyword?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:05 p.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2013_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by knarf):

* milestone: => ET_2013_11

Comment:

I think variable time steps are even usable in Carpet, at least to some extend. We don't have a defined way to tag backports - as it didn't usually need to happen so often. I suggest to use the relevant milestone tag, which I now do here.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:12 p.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2013_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+---------------------------------------

Comment (by diener):

RK87 can also be used with fixed timesteps. But yes, variable timesteps can be used in Carpet, for example when using multiblock and no mesh refinement. This was where it was used initially.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:29 p.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2013_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+---------------------------------------

Comment (by rhaas):

Replying to [comment:5 knarf]:

...

I think variable time steps are even usable in Carpet, at least to some

extend. We don't have a defined way to tag backports - as it didn't usually need to happen so often. I suggest to use the relevant milestone tag, which I now do here.

How did you manage to set a past milestone? I tried doing that but could not find ET_2013_11 in the drop down list of milestones in the Modify Ticket section.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:49 p.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: ET_2013_11 Resolution: | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by knarf):

* version: development version => ET_2013_11 * milestone: ET_2013_11 =>

Comment:

Ok - milestone doesn't work apparently, what about using the "version"?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

20 Dec 20 Dec

12:48 a.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: ET_2013_11 Resolution: fixed | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

fixed in rev 205 of MoL backported to Noether in rev 206.

Re comment:8 : using Version we can only tag a single version so we'd first fix it in trunk (leaving the version at the default) the change the version to the release. This does not seem ideal. It would seem better if one could flag an important ticket for backporting right away.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

4:59 a.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: ET_2013_11 Resolution: fixed | Keywords: MoL backport ------------------------------------+--------------------------------------- Changes (by hinder):

* keywords: MoL => MoL backport

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:01 a.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: ET_2013_11 Resolution: | Keywords: MoL backport ------------------------------------+--------------------------------------- Changes (by hinder):

* status: closed => reopened * resolution: fixed =>

Comment:

Reopening to test backport trac query.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:03 a.m.

#1504: MoL RK87 non-functional ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: ET_2013_11 Resolution: fixed | Keywords: MoL backport ------------------------------------+--------------------------------------- Changes (by hinder):

* status: reopened => closed * resolution: => fixed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1504#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4676

Age (days ago)

4683

Last active (days ago)

trac@lists.einsteintoolkit.org

12 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit