[Einstein Toolkit] #883: MoL: Add declaration of Accelerator_NotifyDataModified to interface
#883: MoL: Add declaration of Accelerator_NotifyDataModified to interface ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: new Priority: blocker | Milestone: ET_2012_05 Component: Cactus | Version: development version Keywords: | ---------------------+------------------------------------------------------ Currently MoL doesn't build because the aliased function Accelerator_NotifyDataModified() is used but not declared in interface.ccl.
The attached patch declares the function which makes the linker happy. The availability of the function is already checked at runtime.
#883: MoL: Add declaration of Accelerator_NotifyDataModified to interface ----------------------+----------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: review Priority: blocker | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: ----------------------+----------------------------------------------------- Changes (by knarf):
* status: new => review
#883: MoL: Add declaration of Accelerator_NotifyDataModified to interface ----------------------+----------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: review Priority: blocker | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------
Comment (by eschnett):
Should this function really be called in MoL, or should this be done only in a development branch?
#883: MoL: Add declaration of Accelerator_NotifyDataModified to interface ----------------------+----------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: review Priority: blocker | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------
Comment (by knarf):
I am not 100% sure. However, at least one other Accelerator_* function is already declared in MoL right now. The patch would let MoL build (link) again. Whether the code calling that function should be in MoL or not would be another question.
#883: MoL: Add declaration of Accelerator_NotifyDataModified to interface ----------------------+----------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: review Priority: blocker | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------
Comment (by eschnett):
I have a current version of MoL (r165), and this aliased function is not called. Can you check your branch?
#883: MoL: Add declaration of Accelerator_NotifyDataModified to interface ----------------------+----------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: closed Priority: blocker | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: invalid | Keywords: ----------------------+----------------------------------------------------- Changes (by knarf):
* status: review => closed * resolution: => invalid
Comment:
You are right. Somehow this checkout switched to another branch, which it shouldn't have done. Committing the patch there and closing here as invalid.
#883: MoL: Add declaration of Accelerator_NotifyDataModified to interface ----------------------+----------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: closed Priority: blocker | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: invalid | Keywords: ----------------------+-----------------------------------------------------
Comment (by hinder):
Sorry - this was also my fault. I forgot to add the interface.ccl declaration in my first commit, and forgot to push the second commit where I corrected this. Thanks for fixing it.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit