#2186: PUGH: support zero sized grid arrays ---------------------------------+----------------------------------- Reporter: Roland Haas | Type: defect Status: new | Priority: minor Milestone: | Component: EinsteinToolkit thorn Version: development version | Keywords: PUGH ---------------------------------+----------------------------------- if a grid array has size 0 we ignore it during communication by setting its ghost size and overlap region to zero, cctk_lsh will show up a zero as well
This fixes the bug that Erik observed in https://bitbucket.org/cactuscode/cactustest/commits/8a6601f about 14 years ago. As far as I can tell this test has been failing since then and only was not caught b/c the testing system actually does not look at the Cactus return code.
Pull request is here: https://bitbucket.org/cactuscode/cactuspugh/pull- requests/2/pugh-support-zero-sized-grid-arrays/diff
#2186: PUGH: support zero sized grid arrays ------------------------------------+--------------------------------- Reporter: Roland Haas | Owner: (none) Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PUGH ------------------------------------+--------------------------------- Changes (by Roland Haas):
* status: new => review
#2186: PUGH: support zero sized grid arrays ------------------------------------+--------------------------------- Reporter: Roland Haas | Owner: (none) Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PUGH ------------------------------------+---------------------------------
Comment (by Roland Haas):
Now that the Wu release is done, it is time to review and include or reject this.
#2186: PUGH: support zero sized grid arrays ------------------------------------+--------------------------------- Reporter: Roland Haas | Owner: (none) Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PUGH ------------------------------------+--------------------------------- Changes (by Steven R. Brandt):
* status: review => reviewed_ok
Comment:
Looks good to me.
#2186: PUGH: support zero sized grid arrays ------------------------------------+--------------------------------- Reporter: Roland Haas | Owner: (none) Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: PUGH ------------------------------------+--------------------------------- Changes (by Roland Haas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Thank you.
Applied as git hash aceef8f "PUGH: support zero sized grid array" of cactuspugh.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit