[Einstein Toolkit] #839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL.

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1000: mistake...

[Einstein Toolkit] #550:...

Einstein Toolkit

30 Apr 2012 30 Apr '12

1:27 p.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. ----------------------------------------+----------------------------------- Reporter: reisswig@… | Type: enhancement Status: new | Priority: optional Milestone: | Component: Cactus Version: | Keywords: MoL Multirate ----------------------------------------+----------------------------------- In order to make multirate work, we need to introduce new registration routines that explicitly register variables with the "slow" sector, i.e. those variables which are integrated by the lower order scheme. This also means that we require new "accumulator" parameters indicating how many "slow" variables we want to register.

Flags indicate whether it is time to execute slow RHS computation. For instance, in the RK4-RK2 scheme, there are 4 substeps in total, but the RK2 RHS are only evaluated in the very first and in the very last step of the four substeps.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

30 Apr 30 Apr

2:22 p.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: Resolution: | Keywords: MoL Multirate -----------------------------------------+---------------------------------- Changes (by rhaas):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2 May 2 May

7:50 p.m.

Comment (by eschnett):

Do you have a test case for this?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:19 p.m.

Comment (by eschnett):

This patch breaks two test cases:

GRHydro_test_tov_ppm_ML_disable_internal_excision (from GRHydro) GRHydro_test_tov_ppm_no_trp_ML (from GRHydro)

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3 May 3 May

10:16 p.m.

Comment (by rhaas):

Erik: both tests pass for me on my workstation (Debian Squeeze/Wheezy, simfactory config filedebian-lenny-gcc.cfg, gcc 4.6, OpenMPI, optimized build, both 2 threads and 4 cores and 2 threasd 2 cores).

Can you provide more details on the machine where it fails, please?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

4 May 4 May

6:33 a.m.

Comment (by eschnett):

I tested this on Bethe.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:18 p.m.

Comment (by rhaas):

Very strange. It torks for me on bethe as well (default simfactory bethe config) with 1 and 2 MPI processes and 4 cores. I committed them into release-info and they can be seen at bethe:/home/rhaas/simulations.

Christian promises a test case using GRHydro.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

4:59 p.m.

Comment (by eschnett):

I believe I used 2 processes and 6 threads.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5 May 5 May

3:25 p.m.

Comment (by rhaas):

Progress of a sort. I can get GRHydro_test_tov_ppm_no_trp_ML test to fail with 6 threads (but not GRHydro_test_tov_ppm_ML_disable_internal_excision). However now it is also failing with 2 threads and also without the MoL patch. Doing a fresh recompile now...

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7 May 7 May

9:29 p.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: optional | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: | Keywords: MoL Multirate -----------------------------------------+---------------------------------- Changes (by eschnett):

* milestone: => ET_2012_05

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

21 May 21 May

10:33 a.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: optional | Milestone: ET_2012_11 Component: Cactus | Version: Resolution: | Keywords: MoL Multirate -----------------------------------------+---------------------------------- Changes (by knarf):

* milestone: ET_2012_05 => ET_2012_11

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11 Jun 11 Jun

10:39 a.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: optional | Milestone: ET_2012_11 Component: Cactus | Version: Resolution: | Keywords: MoL Multirate -----------------------------------------+----------------------------------

Comment (by eschnett):

Has there been progress?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12 Jun 12 Jun

7:22 a.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: optional | Milestone: ET_2012_11 Component: Cactus | Version: Resolution: | Keywords: MoL Multirate -----------------------------------------+----------------------------------

Comment (by reisswig@…):

No, not yet. Still need track down the problem above. I will also prepare a test case.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

31 Jul 31 Jul

7:17 p.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: optional | Milestone: ET_2012_11 Component: Cactus | Version: Resolution: | Keywords: MoL Multirate -----------------------------------------+----------------------------------

Comment (by rhaas):

I attach an updated patch that adds support for the ChangeType like function calls and allows querying of the RHS variable of slow evolved quantities. It corrects some comments as well.

The actual patch is in revised.patch (please ignore revised.2.patch). and differences.diff is a diff between original.patch and revised.patch to illustrate what was changed.

I just tried and the patch passes all tests on bethe with 6 threads and 2 processes (current simfactory options). I thins that the failing test was affected by an OpenMP race condition that was fixed in rev 364 caused by an implicit Fortran SAVE attribute in Con2PrimPolytype_pt (which was used by the test the Erik found to fail since it uses GRHydro::GRHydro_eos_type = "Polytype").

Ok to apply (a test for this is in GRHydro/Zelmani and will be pushed with the next batch of GRhydro updates)?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:13 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2 Aug 2 Aug

7:27 a.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: ET_2012_11 Component: Cactus | Version: Resolution: | Keywords: MoL Multirate -----------------------------------------+---------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

Comment:

I suggest to apply the patch.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:14 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:35 a.m.

#839: MoL Multirate capabilities. This add three new multirate RK schemes to MoL. -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: closed Priority: optional | Milestone: ET_2012_11 Component: Cactus | Version: Resolution: fixed | Keywords: MoL Multirate -----------------------------------------+---------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Applied as ref 175 of MoL.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/839#comment:15 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5180

Age (days ago)

5274

Last active (days ago)

trac@lists.einsteintoolkit.org

15 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit