#683: LSUThorns/Vectors: Remove pos, add sin/cos/tan functions
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Remove kpos, because it is not used (it is a no-op, i.e. the
arithmetic + operator).
Add sin, cos, and tan.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/683>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#223: Make declaration of CCTK_ARGUMENTS safer
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
I suggest to change the declaration of CCTK_ARGUMENTS in C from
cGH * cctkGH
to
cGH const * CCTK_RESTRICT const cctkGH
which should lead to safer code and may even enable some optimisations.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/223>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#688: Carpet timers are slow
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The Carpet timers (file CactusTimers.cc) performs unnecessary work that is
not necessary unless timers_verbose is given. It calls the flesh to obtain
the timer name, converts this to a C++ string (malloc/free), and back to a
C string. This is due to the API of msgStart and msgStop.
The routine serialise changes the output stream properties by modifying
the output format (scientific) and the precision. This should be undone
afterwards in the same routine.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/688>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#687: Display allocation information
-------------------------+--------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
SimFactory could provide a command to display the usage information of the
user's allocation on a machine. For example,
{{{
$ sim show-allocation
Allocation: TG38372811
Total: 100000
Used: 10000
Used by <user>: 50000
Remaining: 90000
}}}
Some systems will not be able to provide all this information, and some
will not have the concept of an allocation. The output should be easy to
parse by scripts (e.g. for updating group web pages).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/687>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
Luca
I didn't mean to disagree with you: it may indeed be time to make
Carpet's ASCII output more user friendly but omitting ghost zones,
i.e. to change the defaults for some of the parameters you mentioned.
However, for the deprecated parameter, the plan is to make them go
away (or to turn them into no-ops, i.e. to completely ignore them in
the code).
-erik
On Sat, Nov 26, 2011 at 8:23 PM, Luca Baiotti <baiotti(a)ile.osaka-u.ac.jp> wrote:
> On 25/11/11 4:58 AM, Einstein Toolkit wrote:
>> #677: parameter default change in CarpetIOASCII
>> ----------------------------------------+-----------------------------------
>> Reporter: baiotti@… | Owner: eschnett
>> Type: enhancement | Status: new
>> Priority: optional | Milestone:
>> Component: Carpet | Version:
>> Resolution: | Keywords: CaroetIOASCII parameter default
>> ----------------------------------------+-----------------------------------
>>
>> Comment (by eschnett):
>>
>> A quick note: If a parameter is deprecated, it should not be used if
>> possible, and consequently its default should not be changed either.
>
> I think that no one uses 3D ASCII output, so those two (of the four)
> parameters are irrelevant, but in general I don't agree. Unless a
> parameter has no effect in the code, a default may be better than
> another, even if the parameter is deprecated.
>
> In the specific case, the proposed default is better. By the way, why
> were the parameters deprecated (again no one uses those two parameters
> anyway I believe)?
>
> Luca
> _______________________________________________
> Users mailing list
> Users(a)einsteintoolkit.org
> http://lists.einsteintoolkit.org/mailman/listinfo/users
>
--
Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/
#679: Add kifneg function
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Subject: Add kifneg function
From: Erik Schnetter <eschnetter(a)perimeterinstitute.ca>
Date: 2011-11-26
Add an kifneg function that does the opposite of kifpos, because
kifneg is more natural (in the same sense as "ifnotzero" is natural in
C.)
Incidentally, it should probably be renamed "ifmsb" instead, because
it can also be applied to unsigned quantities which don't have a sign
bit.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/679>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#425: Case sensitivity GSL_DIR=BUILD
----------------------------------------+-----------------------------------
Reporter: reisswig@… | Type: enhancement
Status: new | Priority: minor
Milestone: | Component: Cactus
Version: | Keywords: GSL_DIR BUILD
----------------------------------------+-----------------------------------
The thorn GSL would not compile if "GSL_DIR=build" in the option list. In
order to work, it requires "GSL_DIR=BUILD", i.e. it is really case
sensitive
although I think, this is not required and should be case insensitive.
Possibly, HDF5_DIR=build may also not work for the same reason (have not
checked; should be checked as well).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/425>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#234: Carpet mailing list is not functioning
--------------------+-------------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: Carpet | Version:
Keywords: |
--------------------+-------------------------------------------------------
The Carpet mailing list has been unavailable since 22-Mar-2010. This list
provides a forum for discussion of Carpet features and issues, and would
be the first port-of-call for new users. As such I think it would be good
to resurrect the mailing list.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/234>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#671: ML_ADMConstraints is incorrect
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: ML_ADMConstraints |
-----------------------------------+----------------------------------------
ML_ADMConstraints does not compute the constraints correctly. There are
errors in the computation of the Ricci tensor. The attached patch
corrects these errors. OK to apply?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/671>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit