#862: Make HDF5 output in AHFinderDirect work
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Ian Hinder sees errors when trying to use HDF5 output of AHFinderDirect. I
see lines "#ifdef CCTK_HDF5" that should probably be "#ifdef
HAVE_CAPABILITY_HDF5" instead. Also, an "OPTIONAL: HDF5" may be missing in
the configuration.ccl.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/862>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#889: GRHydro atmosphere bug
----------------------+-----------------------------------------------------
Reporter: reisswig | Type: defect
Status: new | Priority: critical
Milestone: | Component: EinsteinToolkit thorn
Version: | Keywords: GRHydro, atmosphere
----------------------+-----------------------------------------------------
I have fixed a bug in GRHydro's atmosphere handling after reconstruction.
After reconstruction, the reconstructed plus and minus face values are
tested for whether they drop below atmosphere level and are then reset.
In particular, this means that plus and minus face values for cell i don't
generally coincide with the minus/plus face values of the corresponding
cells i-1 and i+1.
If the reconstruction previously found that the Riemann problem was
trivial between, say rhominus(i+1) and rhoplus(i), when changing
rhoplus(i), it is not anymore!
However, the mask "trivial_rp" testing for a trivial Riemann problem is
not changed!
This leads to inconsistent behavior at the boundary of the atmosphere.
The symptom was a drift in the center of mass of a static and perfectly
symmetric TOV star.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/889>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#827: merge bugfixes from Zelmani into main branch
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
A while ago we moved GRMHD development (for various reasons) from the main
repository into a git repository (Zelmani). Since then we have accumulated
a number of (important) bugfixes (in particular for MHD but also for other
subsystems) in that repository.
Should we mere them back (this soon before the release)?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/827>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#794: Thorn ADMMass should be included in the Einstein Toolkit
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: ET_2012_05
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
There was a discussion
(http://lists.einsteintoolkit.org/pipermail/users/2011-December/thread.html#…)
on the ET mailing list about adding the thorn ADMMass to the toolkit. The
decision was made to do so once some documentation was added. This should
be done before the next release.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/794>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#892: correct column headers hen both one_file_per_group and
all_reductions_in_one_file are active
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: |
--------------------+-------------------------------------------------------
the column labels were sorted the wrong way if both options were active
(nesting of loops was wrong). The attached patches correct this and add
test cases for all 4 combinations of one_file_per_group and
all_reductions_in_one_file.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/892>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#729: RotatingSymmetry90 as applied to pseudo vectors fail
-----------------------------------+----------------------------------------
Reporter: bmundim | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: RotatingSymmetry90 |
-----------------------------------+----------------------------------------
Hi,
doing some tests today with RotatingSymmetry90 today I noticed the
symmetry conditions were not applied correctly for Bvec as defined by
hydrobase:
CCTK_REAL Bvec[3] type = GF Timelevels = 3
tags='ProlongationParameter="HydroBase::prolongation_type"
tensortypealias="U" tensorparity=-1 interpolator="matter"' "Magnetic field
components B^i"
The parity settings used to work until recently. Does anyone know what
could be causing this problem?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/729>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#525: Clean up CCTK_GFINDEX definitions
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
The way in which CCTK_GFINDEX is defined is a bit complex, probably
unnecessarily so. The file cctk.h distinguishes between compilers which
support inlining and compilers which don't. This is probably useless these
days since every compiler supports inlining, and if not, we don't really
expect it to be fast.
If the compiler supports inlining, we define static inline functions,
which may or may not check array indices. If the compiler does not support
inlining, and if CCTK_DEBUG is defined, then we use regular functions
defined in DebugDefines.c, otherwise (i.e. without CCTK_DEBUG) we use
macros.
Overall, the indexing functions are defined three times, including once as
macros. I suggest to simplify this, based on the assumption that every
fast compiler supports inlining. I assume so because (a) the ubiquity of
C++, which relies heavily on inlining, and (b) C99 officially introduced
inlining 12 years ago.
The new setup would have "static inline" definitions (without index
checking) in cctk.h, and would have regular functions (with index
checking) in DebugDefines.c, and would choose between these two
implementations via CCTK_DEBUG.
This would eliminate the macros, and would eliminate the case distinction
based on whether the compiler supports inlining.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/525>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#879: CCZ4 variant of McLachlan should be documented
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2012_05
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The CCZ4 variant of McLachlan should be documented. The McLachlan
documentation currently consists of the file
Cactus/arrangements/McLachlan/doc/mclachlan.tex.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/879>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#867: Add parameter to poison periodic boundaries
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Add a parameter to poison periodic boundaries before the periodicity
condition is applied. This allows detecting errors in the periodicity
boundary condition, which does not work if there are multiple local
components per process.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/867>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit