#456: Ensure functions are not defined twice
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
When multiple source files define non-static functions with the same name,
these are all compiled together into the resulting executable. Which one
gets called is not predictable by the user.
This can happen if a user copies a thorn, modifies it slightly, and
compiles both thorns into the same configuration. This can lead to *very*
difficult-to-find bugs, and it would be helpful if Cactus was able to
prevent this, or at least to mitigate the problem.
At the CST level, Cactus should be able to tell that there are two thorns
which schedule functions with the same name. At the moment, this is not
caught. I propose that this should be a fatal error, as there is no way
to predict which function will be called eventually.
This will solve the problem in some cases, but not in the case where there
are instances of duplicate function names which are not scheduled. It
should be possible to scan the object/library files using standard tools
(nm etc) to determine if there are multiple globally visible symbols with
the same name. There might even be standard tools for this purpose.
Doing this in a portable way might not be straightforward, but having an
implementation for Linux, for example, would catch the majority of cases.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/456>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1195: Modify bisection algorithm in EOS_Omni's nuc_eos
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
EOS_Omni's nuc_eos routines use a bisection method to find the temperature
for a given internal energy. This bisects on the temperature T. I suggest
to bisect on log T instead, which is a more natural operation.
For example, if the temperature range is [1...1000] in some units, then
bisecting in T will examine the sequence 500, 250, 125, ..., and will thus
perform many table lookups until (say) T=10 is reached. Bisecting in log T
will find this result much faster.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1195>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#447: simfactory 1.0 always uses -L 3
----------------------------------------------+-----------------------------
Reporter: alexander.beck-ratzka@… | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
----------------------------------------------+-----------------------------
The perl version of simfactory always uses the debugging loglevel for
simulations. The loglevel of a cactus simulation can be specified by
setting -L to a value between 0 (none) and 3 (debug). While the cactus
default is 0, simfactory sets it to 3. The debug loglevel could lead to
huge output files.
I would suggest to set it to the cactus default, and allow a user to
increase it.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/447>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#107: Update released einsteintoolkit.bib once we have a more final version
-----------------------+----------------------------------------------------
Reporter: anonymous | Type: task
Status: new | Priority: major
Milestone: | Component: EinsteinToolkit website
Version: | Keywords:
-----------------------+----------------------------------------------------
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/107>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1299: Correct ET logo on https://www.ohloh.net/p/einsteintoolkit
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
----------------------+-----------------------------------------------------
The Einstein Toolkit logo on <https://www.ohloh.net/p/einsteintoolkit>
looks bad, because it has the wrong aspect ratio. We should upload a
square logo instead.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1299>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#346: Detect when --reconfig is necessary
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
----------------------+-----------------------------------------------------
Cactus sometimes outputs an error message that a configuration needs to be
reconfigured. Simfactory should notice this, and then automatically build
with --reconfig.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/346>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1065: Pass CCTK_ARGUMENTS more efficiently in Fortran
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
CCTK_ARGUMENTS is passed differently in C and in Fortran. In C, only a
single pointer is passed, pointing to cctkGH. The cctk_... variables and
pointers to grid functions are defined locally from cctkGH. This is
efficient, because (a) only a single variable is passed, and (b) the
compiler can eliminate unused definitions.
In Fortran, all the cctk_... variables and all grid functions are passed
explicitly. This is expensive for the caller, because hundreds of
arguments have to be set up and passed to the subroutine. The compiler
cannot eliminate any unused variables.
I suggest to change the Fortran calling convention to be the same as the
one for C. Since regular Fortran pointers differ significantly from C
pointers, I suggest to use "Cray pointers" instead, which are very similar
to C pointers. Cray pointers are an extension to the Fortran standard, and
are supported by all Fortran compilers I know of.
I attach sample code that shows how to declare, define, and use this
convention.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1065>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1015: increase file size limit
----------------------------------+-----------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit trac | Version:
Keywords: |
----------------------------------+-----------------------------------------
Could we increase the size limit for attached files, please? Right now it
seems to be 256k which is regularly too small if I have to attach a patch
with test data. I don't really like splitting up patches into a code patch
(uncompressed) and a gzipped data patch for the test data all the time. It
is just very very error prone.
At least for logged in users.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1015>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#907: TRAC: allow to create a ticket with review state
----------------------------------+-----------------------------------------
Reporter: bmundim | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit trac | Version:
Keywords: TRAC |
----------------------------------+-----------------------------------------
Sometimes we want to create a ticket with an attached patch and assign the
ticket to be reviewed. That should be possible with only one "modify
ticket". Currently we need to create the ticket with the attachment and
then modify the ticket afterwards to review state. The problem is that
sometimes we forget to change to review state. It would be nice to do it
all at once.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/907>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1044: Gnuplot Cactus visualisation page has multiple issues
----------------------------+-----------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus website | Version:
Keywords: |
----------------------------+-----------------------------------------------
The page http://cactuscode.org/documentation/visualization/gnuPlot/ has
the following problems:
* The instructions for viewing multi-iteration 1D data from the
IOASCII thorn do not work. Since the iterations are separated by only a
single blank line, you cannot use the "index" option in the Gnuplot "plot"
command as the instructions tell you to do. I suspect that either the
output format or Gnuplot itself has changed since the instructions were
written. Erik suggests using some form of "every" to visualise this data
in Gnuplot.
* This page renders poorly in both Safari (webkit) and Firefox
(gecko). The light blue boxes containing text to be typed have a strange
artefact on the left side, and the initial paragraph is wrapped poorly.
* All of the links in the table of contents are broken.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1044>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit