#1171: WeylScal4 schedule order is incorrect
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: WeylScal4 testsuite |
-----------------------------------+----------------------------------------
WeylScal4 contains a calculation for computing the I and J invariants from
the Psis. This calculation is not scheduled explicitly after the Psis.
Therefore, Cactus will probably schedule the routines alphabetically,
which should be wrong. This should be corrected either with an After or
Schedule element in the calculation.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1171>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1333: Fortran module in GRHydro_InterfacesM.h is nonsensical
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: GRHydro |
-----------------------------------+----------------------------------------
since
1.) the module is stored in a .h file
2.) the .h file is included at the *top* of .F90 files
3.) the routines for which modules are declared are mostly C routines that
do not live in a module
as a result should one actually "use" the module in eg con2prim then one
would get a link time error looking for the non-existent fortran module
routine
I probably also creates all kinds of race conditions to have the same
module defined in more than one source file, it also carefully circumvents
the Cactus module tracking mechanism.
It is highly confusing and misleading to have the module present when in
fact it cannot be used.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1333>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1316: Piraha's smart_ptr should be in namespace
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2013_05
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
Piraha defines a helper class smart_ptr (and smart_ptr_guts). These should
be located in a namespace.
Probably all of Piraha should be in the namespace cctk. As is, any user
who tried to use Piraha in a thorn would be out of luck, since the name
"piraha" is now globally already taken.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1316>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1315: src/piraha/smart_ptr.hpp has wrong licence
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2013_05
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
Cactus (the flesh) is distributed under the LGPL. However, the file
src/piraha/smart_ptr.hpp has a statement that it is distributed under the
Boost licence. This should be rectified.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1315>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1275: simfactory knows about TerminationTrigger but not TriggerTerminationManual
-------------------------+--------------------------------------------------
Reporter: knarf | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
Currently, simfactory knows about TerminationTrigger but not
TriggerTerminationManual and sets the corresponding max_walltime parameter
correctly for the first but not the second. This small patch does so also
for the second thorn (found in Zelmani).
This should be independent of the question why there are two of these
thorns (which would be a good one to answer), or whether one of them could
be retired or both of them merged. They are currently both used in
production and simfactory should know about both.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1275>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#283: Update and make CoreDoc.pdf available in the EinsteinToolkit website
-------------------------------------+--------------------------------------
Reporter: bmundim | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit website | Version:
Keywords: |
-------------------------------------+--------------------------------------
The advanced concepts document:
http://cactuscode.org/documentation/CoreDoc.pdf
should be updated and made available in the ET website, both in pdf and
html.
Does anyone know where its .tex file version is located?
Thanks,
Bruno.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/283>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#931: CartGrid3D's dependency on Boundary
--------------------+-------------------------------------------------------
Reporter: jtao | Owner:
Type: defect | Status: new
Priority: minor | Milestone: Cactus_4.1.0
Component: Cactus | Version: Cactus_4.0.0
Keywords: |
--------------------+-------------------------------------------------------
CartGrid3D_ApplyBC in CartGrid3D is scheduled in BoundaryConditions, which
is defined in the Boundary thorn.
I can see that this is related with the symmetric boundary conditions but
could we handle it in boundary ?
It seems to me that it is not a good idea to have the grid thorn depend on
the boundary thorn. While making boundary depending on grid is more
reasonable if we have to introduce the dependency between these two
thorns.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/931>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#808: testsuites in HDF5
-------------------------+--------------------------------------------------
Reporter: jtao | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone: Cactus_4.1.0
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
Instead of constructing tools to compare Carpet ascii output from multiple
processes, how about building tools to diff files HDF5 ?
Compared to ASCII:
HDF5 testsuites may have several advantages:
small, fast, portable, independent of number of process.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/808>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1334: CCTK_CHECK_HEADER_LIB_FUNC adds library multiple times to $LIBS
--------------------+-------------------------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: minor | Milestone: ET_2013_05
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
CCTK_CHECK_HEADER_LIB_FUNC (in aclocal.m4) adds its second argument to
$LIBS, every time it is called. I found 8 invocations in configure.in,
each time adding the math library, resulting in a very weird (but not
necessarily wrong) link line in Cactus.
I am not entirely sure about what to do here, but my best guess is that
$LIBS shouldn't be changed at all after this function was called. An
alternative would be to check for the existance of $2 in $LIBS before it
is unconditionally added.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1334>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1111: Missing fortran compiler prevents CCTK_REAL8 from being defined.
---------------------+------------------------------------------------------
Reporter: sbrandt | Owner:
Type: defect | Status: new
Priority: major | Milestone: Cactus_4.1.0
Component: Cactus | Version: Cactus_4.0.0
Keywords: |
---------------------+------------------------------------------------------
If the fortran compiler is missing or invalid, Cactus does not create the
definition for CCTK_REAL8, CCTK_REAL4, etc.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1111>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit