#626: Recovery fails in AHFinderDirect RecoverML with out-of-bounds assertion in
CarpetLib
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone: ET_2011_10
Component: Carpet | Version:
Keywords: |
--------------------+-------------------------------------------------------
when trying to recover in AHFinderDirect's RecoverML test (parfiles
attached) I get:
{{{
cactus_et:
/home/rhaas/ET_2011_10/arrangements/Carpet/CarpetLib/src/th.hh:79: double
th::get_time(int, int, int) const: Assertion `tl>=0 and tl<timelevels'
failed.
}}}
After some debuggin I traced this down to the metric which in
CarpetIOHDF5/src/Input.cc:762 is reported (by gf->timelevels (ml, rl)) to
have three timelevels. However the timelevels member of gf->t (a th) gives
the number of timelevels as two
{{{
gf->t.timelevels
$28 = 2
}}}
Since timelevels is new in Carpet/Hg my suspicion would be that it is not
properly updated when gf->set_timelevels is called (the comments in th.hh
seem to indicated that it is assumed to be const which seems odd given
that ggf::set_timelevels exists).
I don't understand enough of Carpet to fix or further debug this. Marking
its as major and release relevant in case it is actually a Carpet bug.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/626>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1364: be mor careful extracting $MAKE in RunTestSuite
------------------------+---------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: critical | Milestone: ET_2013_05
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
currently sim --testsuite fails on kraken since the extracted $MAKE
command is incorrect since it splits at the second "=" in the make
definition:
{{{
make = env
LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/opt/gcc/4.5.1/snos/lib64:/opt/gcc/mpc/0.8.1/lib"
make -j2
}}}
the attached patch rectifies this. Tested on kraken and lonestar.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1364>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1392: loopcontrol outputs nan values
--------------------+-------------------------------------------------------
Reporter: knarf | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone: ET_2013_11
Component: Carpet | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
After a recent update of carpet, some of my par files produce output like
this:
{{{
INFO (LoopControl): LoopControl statistics:
INFO (LoopControl): Loops traversed: 4
INFO (LoopControl): Setups encountered: 14
INFO (LoopControl): Params explored: 14
INFO (LoopControl): Unoptimized time would have been: -nan s
INFO (LoopControl): Actual time spent: -nan s (-nan%)
INFO (LoopControl): Ideal time could have been: -nan s (-nan%)
}}}
Although no problem for the run, the 'nan's should probably not be output
in that way.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1392>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1251: Use Parsing Expression Grammar for Par Files
-------------------------+--------------------------------------------------
Reporter: sbrandt | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
Piraha is a parsing framework/library based on Parsing Expression Grammars
(PEGs). This allows you to define the grammar of a language using a
simple regular-expression-type language, and Piraha will use this to
decode an input file into a hierarchical data structure of the parsed data
(a "parse tree"). See http://code.google.com/p/piraha-peg/,
http://en.wikipedia.org/wiki/Parsing_expression_grammar.
I've hacked a version of Cactus to use Piraha for parameter parsing.
Please take a look:
https://svn.cactuscode.org/flesh/branches/with_piraha
This version is able to run the ET testsuite.
This version can understand the variables $parfile, $ENV{name}, and $pi
(which is 3.14...). Variables can be standalone, or be substituted from
inside strings.
It can understand mathematical expressions including grouping, order of
operation, and a few functions (sin, cos, tan, exp, sqrt). Other
parameters from the parameter file are available for use in mathematical
expressions.
Some debug printing is in place so you can get an idea of what's going on.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1251>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1066: Implement IMEX integrators in MoL
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Dana Alic contributed an implementation of IMEX integrators for MoL.
I attach the implementation as a patch (based on r133 of MoL). The
implementation is well tested. The patch does not apply cleanly, and seems
to make some modifications to the schedule etc. as well that have since
been superseded by other changes to MoL.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1066>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#652: CACTUS_CONFIGS_DIR should be documented
-------------------------+--------------------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
At the moment CACTUS_CONFIGS_DIR is only mentioned in doc/FAQ. It should
be documented in the regular documentation as well.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/652>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#963: Improve McLachlan accuracy
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
James van Meter provided me with an optimised version of McLachlan. He
states:
1. You are not taking full advantage of the chi=exp(-2phi) variable.
There are several terms you divide by chi or chi^2 in expressions with
overall factors exp(-4phi). I rewrote the BSSN equations to make these
cancellations before coding. So where you have an expression of the form
chi^2(A+B/chi^2), I have chi^2A+B. This gives a slight but noticeable
advantage in both accuracy and performance.
2. I added Hamiltonian-constraint-damping terms due to Duez et al. These
terms don't seem to be well-known but they are effective.
3. I added a Gamma-constraint-damping term due to Yo et al.
4. I enforce det(g)=1.
I have not tested this new version yet, but James suggests to include it
into the Einstein Toolkit.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/963>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1372: AHFinderDirect/misner1.2-025 test fails on datura in ET_2013_05 release
branch
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: AHFinderDirect |
-----------------------------------+----------------------------------------
AHFinderDirect/misner1.2-025 test fails on datura in ET_2013_05 release
branch. Diffs are:
{{{
BH_diagnostics.ah1.gp: differences below tolerance on 1 lines
BH_diagnostics.ah2.gp: differences below tolerance on 1 lines
h.t0.ah1.gp: differences below tolerance on 703 lines
h.t0.ah2.gp: differences below tolerance on 698 lines
sf_area[0].xg: differences below tolerance on 1 lines
sf_min_radius[0].xg: differences below tolerance on 1 lines
sf_radius[0]_2D.asc: differences below tolerance on 496 lines
sf_radius[1]_2D.asc: substantial differences
significant differences on 5 (out of 1058) lines
maximum absolute difference in column 3 is 1.75718694541256e+243
maximum relative difference in column 3 is 2899588673.18783
(insignificant differences on 37 lines)
}}}
Since this does not fail in the ubuntu test VM, it might be something to
do with the Intel compiler vs GCC.
According to http://einsteintoolkit.org/release-
info/parse_testsuite_results.php, it seems that this test was failing on a
number of machines for a while.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1372>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1398: make evolution_method etc. parameters of ADMBase steerable
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: ADMBase |
-----------------------------------+----------------------------------------
this is occasionally useful to continue a run that started in Cowling
approximation using a spacetime thorn (or the other way around, continue
in cowling once the spacetime settles down to a stationary state).
The attached patch makes all but the initial data parameters of admbase
steerable on recovery.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1398>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1254: Simplify SimFactory's get-output-dir command
-------------------------+--------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
Currently, sim get-output-dir returns:
{{{
Simulation name: <simname>
Output directory: <basedir>/<simname>/output-NNNN/<parbasename>
}}}
I think most uses of this command would be in shell scripts, where it
would be easier to use if it only output the actual output directory. The
first line is redundant, as the user has already specified the simulation
name. Also, simfactory is appending the <parbasename>, and assuming that
such a directory exists and contains some useful data. Without parsing
the parameter file and duplicating cactus logic, it cannot know where the
actual data is. I think simfactory should just give the output-0000
directory, and leave it up to the user to figure out where to find the
data in there. The attached patch implements this change. OK to apply?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1254>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit