#605: Simfactory does not find the right 'path' for symlinked cactus directories
------------------------+---------------------------------------------------
Reporter: knarf | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone: ET_2011_10
Component: SimFactory | Version: development version
Keywords: |
------------------------+---------------------------------------------------
Simfactory currently does not detect the 'right' path to a Cactus
sourcetree if this is from within a symlink, e.g. Cactus ->
/mnt/data/Cactus. This is because while `pwd` returns '/home/user/Cactus',
simfactory uses a wrapper to the C-library getcwd(), which dereferences
symlinks. Simfactory then gets '/mnt/data/Cactus' and tries to use this
path on remote machines when syncing - which of course does not work.
The attached patch fixes this by using os.environ.get("PWD") and, if this
is not defined, using os.getcwd() as workaround.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/605>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#117: Error while building multiple configurations
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: mthomas
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
I wanted to build multiple configurations at once with the command
./simfactory/sim build sim-debug sim
sim-debug is a debug configuration, sim is optimised. SimFactory built
sim-debug, then aborted with the error:
optionlist is: /Users/eschnett/EinsteinToolkit-hg/configs/sim/OptionList
Error: pattern '^\s*DEBUG\s*=.*$' exists already
It assumes that SimFactory doesn't properly distinguish between the
different build options of the different configurations.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/117>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1303: document syntax of new parameter file parser
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
--------------------+-------------------------------------------------------
currently we have no documentation as to what format the new parser
accepts. As a matter of fact the documentation in the UsersGuide (see
http://einsteintoolkit.org/documentation/UsersGuide/UsersGuidech7.html#x10-…)
is in contradiction with what the parser will allow:
{{{
* The parameter file is read sequentially from top to bottom, this means
that if you set the value of a parameter twice in the parameter file, the
second value will be used.
* String parameter values can be specified either as unquoted tokens (not
containing any whitespace), or as quoted values. If a quoted string
parameter value spans multiple lines, all whitespaces, including newline
characters, are preserved.
}}}
which will fail. Actually the first one is already incorrect with the
current implementation which does not allow a parameter to be set twice
(since this is often a sign of a user error).
While this is "just" documentation, I'll still flag it as major since the
parser is so fundamental.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1303>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1306: problem with creating a new project with an existing cactus directory
----------------------------------------+-----------------------------------
Reporter: srichers@… | Owner: sbrandt
Type: defect | Status: new
Priority: minor | Milestone:
Component: Mojave | Version:
Keywords: |
----------------------------------------+-----------------------------------
When a new project is created and fed the location of a local Cactus
directory, the Mojave 'build' command does not work right away because it
tries to execute simfactory from the workspace directory. It would be nice
if the commands were executed in the existing directory rather than the
workspace one so the .mojave.xml file doesn't have to be changed. (or a
basedir variable in the mojave.xml file could be added and prepended to
each filename)
Also, the indexer does not work properly for new projects with an existing
cactus directory. It does not recognize anything (cactus types, functions
from other files, etc). It works somewhat better, though not completely,
if the Cactus directory is put into the appropriate folder in workspace/
before creating the project. (recognizes Cactus internals, but not e.g.
functions defined in other thorns)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1306>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1270: Formaline doesn't understand CACTUS_CONFIGS_DIR
-----------------------+----------------------------------------------------
Reporter: sbrandt | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2013_05
Component: Other | Version: development version
Keywords: Formaline |
-----------------------+----------------------------------------------------
When building with Formaline and CACTUS_CONFIGS_DIR one sees error
messages of the form seen below. It is easily fixed though. See patch.
COMPILING /home/sbrandt/workspace/funwave2/Cactus/src/main/Parameters.c
Updating /home/sbrandt/.mojaveconfig/funwave2/Cfg1/lib/libthorn_Cactus.a
Checking status of thorn CactusBindings
find: `configs/Cfg1/ThornList': No such file or directory
find: `configs/Cfg1/config-data': No such file or directory
find: `configs/Cfg1/config-info': No such file or directory
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1270>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#874: Reduce warnings during an ET build
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
--------------------+-------------------------------------------------------
A new user of the ET might be disconcerted to see warnings during
compilation such as:
{{{
/home/ianhin/Cactus/EinsteinToolkit/arrangements/Carpet/CarpetLib/src/bboxset.hh(206):
warning #1224: #warning directive: "TODO: this is incorrect"
#warning "TODO: this is incorrect"
^
}}}
I propose that such directives are replaced with a comment and a link to a
TRAC ticket concerning the problem.
Further, we should aim to eliminate as many warnings as possible from the
build, similarly to avoid eroding confidence.
Warnings can also make it hard to find the real error messages, when a
build fails with errors.
Other warnings I see are similar to:
{{{
In file included from
/home/ianhin/Cactus/GBSC12/arrangements/CactusUtils/Formaline/src/thornlist.cc:13:
/home/ianhin/Cactus/GBSC12/configs/bbh/bindings/include/thornlist.h:61:
warning: deprecated conversion from
string constant to ‘char*’
}}}
{{{
/home/ianhin/Cactus/GBSC12/arrangements/EinsteinInitialData/TwoPunctures/src/Newton.c:
In function ‘TestRelax’:
/home/ianhin/Cactus/GBSC12/arrangements/EinsteinInitialData/TwoPunctures/src/Newton.c:287:
warning: passing
argument 6 of ‘resid’ from incompatible pointer type
/home/ianhin/Cactus/GBSC12/arrangements/EinsteinInitialData/TwoPunctures/src/Newton.c:75:
note: expected
‘const int * const restrict* const restrict’ but argument is of type ‘int
**’
}}}
{{{
/home/ianhin/Cactus/GBSC12/configs/bbh/bindings/Variables/ADMBase.c: In
function ‘CCTKi_BindingsFortranWrapperADMBase’:
/home/ianhin/Cactus/GBSC12/configs/bbh/bindings/Variables/ADMBase.c:34:
warning: passing argument 22 of ‘function’
from incompatible pointer type
/home/ianhin/Cactus/GBSC12/configs/bbh/bindings/Variables/ADMBase.c:34:
note: expected ‘const struct cGH * const*’
but argument is of type ‘struct cGH **’
}}}
This last warning appears very many times during a build (though I believe
it may be triggered only by GCC and not by the Intel compiler).
{{{
/home/ianhin/Cactus/GBSC12/src/main/Parameters.c: In function
‘ParameterSetBoolean’:
/home/ianhin/Cactus/GBSC12/src/main/Parameters.c:2394: warning: passing
argument 4 of ‘Util_ExpressionEvaluate’
discards qualifiers from pointer target type
/home/ianhin/Cactus/GBSC12/src/include/util_Expression.h:38: note:
expected ‘void *’ but argument is of type
‘const int *’
}}}
There are probably more as well.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/874>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90,
RotatingSymmetry180, etc.
---------------------------------------------------+------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: RotatingSymmetry180RotatingSymmetry90 |
---------------------------------------------------+------------------------
I think only the RotatingSymmetry ones need work since Peridic does not
need to know what type of object it acts on. See #1236
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1371>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1406: Commit r5034 to the flesh breaks many external libraries
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner: knarf@…
Type: defect | Status: new
Priority: blocker | Milestone:
Component: Cactus | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
Commit r5034 modified the options that are passed to external libraries. I
see build failures on machines using the Intel compiler. Reverting this
commit seems to cure the problem. Frank Löffler and I are investigating.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1406>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1408: Many tests failing after Carpet changes
----------------------+-----------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: critical | Milestone:
Component: Carpet | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
17 new failures after
{{{
* repos/carpet c4ed131...e6d4320 (3):
> LoopControl: Declare some variables as potentially unused
> CarpetLib: Use OpenMP collapse clause in Fortran transport operators
> CarpetLib: New parameter use_loopcontrol_in_operators
}}}
https://build.barrywardell.net/job/EinsteinToolkit/674/changes
Failures:
https://build.barrywardell.net/job/EinsteinToolkit/674/testReport/?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1408>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#780: missing small packages
----------------------------------------------+-----------------------------
Reporter: knarf | Owner: dcastl2
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Einstein Toolkit Virtual Machine | Version:
Keywords: |
----------------------------------------------+-----------------------------
Some tools to be installed:
mmv
screen
tmux
texlive (probably quite large, but also probably necessary)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/780>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit