#1631: The dgfe branch for McLachlan generates NaNs
-----------------------------------------------------------+----------------
Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett
Type: defect | Status: new
Priority: optional | Milestone: ET_2014_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: dgfe,mclachlan,gamma driver |
-----------------------------------------------------------+----------------
When one uses the gamma driver formulation in the dgfe branch of McLachlan
and sets the shiftGammaCoefficient to zero, the runtime output has NaNs
because the code divides by zero.
A bit of flow control fixes this. Attached is a patch for the branch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1631>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1646: McLachlan does not give a reference for the gauge evolution equations
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: McLachlan |
-----------------------------------+----------------------------------------
McLachlan_BSSN.m does not seem to contain any information (eg in evolCalc)
that would tell me from which paper the different expressions for the
shift and lapse evolution expression are taken from (which may be useful
to understand what the different coefficients mean, since parsing the
multiple factors of the type XXXFactor * AAA + (1-XXXFactor) * BBB to get
either AAA or BBB is confusing).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1646>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1419: Cactus should produce no errors in Valgrind
-------------------------+--------------------------------------------------
Reporter: sbrandt | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: Cactus_4.3.0
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
Valgrind is a useful tool for identifying a large number of coding
problems. Currently, running Cactus under valgrind produces a large number
of spurious errors due to the implementation of the string library.
Attempts to use the valgrind suppression mechanism to eliminate them have
proven difficult.
However, these errors all go away if we simply replace all calls to
strdup() with calls to util_Strdup(), a function which is already part of
Cactus. Making this replacement shouldn't have any negative impacts, and
it would make valgrind more usable.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1419>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#706: External Library Support
-------------------------+--------------------------------------------------
Reporter: sbrandt | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: Cactus_4.1.0
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
We should remove support for all external library support that's wired
into the flesh (except maybe MPI) in favor of the newer more generic
mechanism.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/706>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#641: Parameter files and thornlists could be tested as part of the release
process
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2012_05
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
There are a number of parameter files and thornlists included as examples
with thorns in the ET, and in Cactus. Would it be feasible to have these
tested as part of the release process? For example, they should run
without crashing or missing thorns, should not trigger NaNs etc, and we
should minimise any warnings that are emitted. It would be nice to
automate this, though it probably requires a cluster, so would be distinct
from the usual test suite procedure, due to requiring more memory than
tests.
Something to think about for the next release.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/641>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#697: Repository and thorn names cannot be different
---------------------------+------------------------------------------------
Reporter: eschnett | Owner: eric9
Type: defect | Status: new
Priority: critical | Milestone:
Component: GetComponents | Version:
Keywords: |
---------------------------+------------------------------------------------
I am accessing some thorns stored in git repositories at bitbucket.org,
which insists that all repository names are all lower case. I don't know
how to specify this in GetComponents. When I say
!TARGET = $ARR
!TYPE = git
!URL = git@bitbucket.org:user/thorn.git
!AUTH_URL = git@bitbucket.org:user/thorn.git
!CHECKOUT =
Arrangement/Thorn
then GetComponents does not create a symbolic link from Thorn to
../../repos/thorn, but to ../../repos/thorn/Arrangement/Thorn instead. How
do I avoid this?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/697>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#241: Thorns should be able to specify implementation versions, and other thorns
should be able to depend on those
-------------------------+--------------------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
Cactus thorns implement 'implementations', and other thorns can then
depend on particular implementations being present. However, quite often
those are updated, and incompatibilities occur. Usually this is resolved
by the developer in both thorns - the implementing and the using thorn.
However, a user might just update one of them, and Cactus would not catch
this error. Thus, I suggest to think about, and implement how to:
- specify implementation versions
e.g. IMPLEMENTS: Cactus (4.0)
The version string within () would have be sorted in an intelligent way
to allow
comparisons [1].
- specify dependencies on particular versions of other implementations
In particular I suggest the following dependencies: depends, and
conflicts, both
with comparisons < <= == >= > !=
e.g. DEPENDS: Cactus (>= 4.0)
DEPENDS: BadImplementation (!=3.14) <-- this introduces a
dependency
CONFLICTS: BadImplementation (==3.14) <-- this doesn't introduce
a depencency
[1] First the initial part of each string consisting entirely of non-digit
characters is determined. These two parts (one of which may be empty) are
compared lexically. If a difference is found it is returned. The lexical
comparison is a comparison of ASCII values modified so that all the
letters sort earlier than all the non-letters. Then the initial part of
the remainder of each string which consists entirely of digit characters
is determined. The numerical values of these two parts are compared, and
any difference found is returned as the result of the comparison. For
these purposes an empty string (which can only occur at the end of one or
both version strings being compared) counts as zero.
These two steps (comparing and removing initial non-digit strings and
initial digit strings) are repeated until a difference is found or both
strings are exhausted.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/241>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1033: support a combined "map" file in CarpetIOHDF5
--------------------------+-------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: CarpetIOHDF5 |
--------------------------+-------------------------------------------------
recovering on different number of processes than was used to write a
checkpoint is painfully slow. Part of the reason seems to be that each
process essentially has to read all files to find out where each piece of
data it requires is located. The attached patch (not to be included in the
main code due to bad file formats and coding) enables CarpetIOHDF5 to read
all the information stored in the union of index files to from a single
file. This means (together with the other patches proposed today) that
CarpetIOHDF5 only ever opens those HDF5 files that are required to restore
the simulation on a given process. It significantly (factor > 4 where I
don't quite know how fast since the unpatched version ran out of walltime)
speeds up recovery with many more processors than wrote the files.
It also adds an optimization for CCTK_VarIndex calls inside CarpetIOHDF5
(which happens for every dataset in the file).
This is intended only as a proof of what might speed up recovery. A proper
implementation would need a more sensible file format. Two option seem
possible:
1) extend the index file format by a "filename" or "filenum" attribute to
each dataset and use a concatenation of all index files as the map file
2) define a custom hdf5 data type corresponding to the information in a
single patch_t, which would have mostly integer field plus two variable
length / enumerated ASCII fields (for the patch name, variable name)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1033>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1045: URL field should be optional
---------------------------+------------------------------------------------
Reporter: hinder | Owner: eric9
Type: defect | Status: new
Priority: minor | Milestone:
Component: GetComponents | Version:
Keywords: |
---------------------------+------------------------------------------------
In a CRL file, it should be possible to have only an AUTH_URL field and
omit the URL field, since it might be that there is no unauthenticated way
to access the repository (e.g. for private repositories). At the moment,
when I omit the URL field for a Git repository, the error message is:
{{{
Use of uninitialized value $git_repo in substitution (s///) at
./GetComponents line 589.
Use of uninitialized value $git_repo in substitution (s///) at
./GetComponents line 590.
Use of uninitialized value $rec{"GIT_REPO"} in substitution (s///) at
./GetComponents line 593.
Use of uninitialized value $rec{"GIT_REPO"} in substitution (s///) at
./GetComponents line 594.
...
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1045>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#334: unsuccessful qsub not recognized / submit succeeds for finished simulation
------------------------+---------------------------------------------------
Reporter: knarf | Owner: mthomas
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
python version:
I submitted a simulation 'sim submit' but the corresponding qsub failed
due to wrong numbers of procs/node (philip cluster). I changed the number
given on the command line and did a 'sim submit' again, this time
successful. Several things happend which I think could be done better:
- the unsuccessful qsub was not detected during the new submit - it
attempted a restart and didn't simply clean
the unsuccessful submit
- when trying the restart, it went ahead and queued the job, but this
later failed when run with "cannot rerun a restart that has been
finished". This could have been caught earlier - without the wait time in
the queue.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/334>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit