#1615: TOVSolver shares parameters from GRHydro
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: TOVSolver |
-----------------------------------+----------------------------------------
Zach Etienne was looking at TOVSolver to use it for a test case in
IllinoisGRMHD (and to compare to GRHydro). He found that it
Turns out all but one of the parameters that are shared with GRHydro are
unused in TOVSolver:
These need to be removed:
USES real rho_abs_min
USES real rho_rel_min
USES REAL initial_rho_abs_min
USES REAL initial_rho_rel_min
USES REAL initial_atmosphere_factor
and that the one shared parameter that is actually used is
GRHydro_rho_central.
My suggestion would to remove these dependencies so that the initial data
thorn can be used with other evolution thorns.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1615>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1059: simfactory silent error
--------------------------------------+-------------------------------------
Reporter: anonymous | Owner: eschnett
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: SimFactory | Version:
Keywords: simfactory error message |
--------------------------------------+-------------------------------------
When sim submit -remote ... fails to queue a job because the allocation
has been overdrawn, simfactory does not print any error message to screen
(it is only hidden in the log file).
Could it be made to print an error message to screen?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1059>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#959: Move pthreads to ExternalLibraries
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
We should move pthreads support to ExternalLibraries (or to the flesh).
I have asked CCT to create the respective repository.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/959>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1579: GRHydro does not build on Blue Gene/Q
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Other | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
Some of the C++ source files in GRHydro do not build on a Blue Gene/Q with
IBM's compiler. The problem is that the compiler takes a very long time
(>8h) even without (sic!) optimization. "The usual" playing with compiler
options or changes to the source files had no effect.
I consider this to be a bug in the compiler. A work-around may be to
switch to Clang as C++ compiler.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1579>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#816: include SphericalHarmonicReconASCII from incoming in PITTNULLCode
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Christian Reisswig provided a copy of SphericalHarmonicReconASCII and
alternative thorn that reads in CCE boundary data (similar
SphericalHarmonicRecon) but supporting a wider variety of input file
formats (HDF5 among them, irrespective of the name).
Used by SpEC and Llama.
There are no docs or test cases as of now. Test data would be welcome
(SpEC, Llama or Cactus provided, I don't think it makes a difference).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/816>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1779: hwloc-utils fails due to missing hwloc-assemlber (and possibly others)
-----------------------------------+----------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: minor | Milestone: ET_2015_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
Currently, make sim-utils fails for me:
{{{
make[1]: *** No rule to make target '/home/knarf/ET_dev/exe/sim/hwloc-
assembler', needed by 'utils'. Stop.
Makefile:870: recipe for target 'sim-utils' failed
}}}
Indeed, I don't have the tool hwloc-assembler installed, although I do
have the hwloc library installed, and it is picked up by the hwloc thorn,
and Cactus succeeds in building the executable. In fact, no binary is
installed with the standard hwloc library package, there is another
package for the utilities. As long as we don't need these utilities I
suggest to not depend on them.
The following patch follows the example of PAPI and only installs known
tools that are actually present in the installation.
{{{
Index: make.configuration.defn
===================================================================
--- make.configuration.defn (revision 66)
+++ make.configuration.defn (working copy)
@@ -1,4 +1,5 @@
# make.configuration.defn file for thorn hwloc
# Define the hwloc utilities
-ALL_UTILS += hwloc-assembler hwloc-assembler-remote hwloc-bind hwloc-calc
hwloc-distances hwloc-distrib hwloc-info hwloc-ls hwloc-ps lstopo lstopo-
no-graphics
+STD_HWLOC_UTILS = hwloc-assembler hwloc-assembler-remote hwloc-bind
hwloc-calc hwloc-distances hwloc-distrib hwloc-info hwloc-ls hwloc-ps
lstopo lstopo-no-graphics
+ALL_UTILS += $(filter $(STD_HWLOC_UTILS), $(notdir $(wildcard
$(HWLOC_DIR)/bin/*)))
}}}
We might even think about backporting this change. I would support this,
but would not go ahead without at least one other maintainer approving.
Obviously after testing...
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1779>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1787: Generalize fallback definition of C++11 static_assert
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
See <https://bitbucket.org/cactuscode/cactus/pull-request/14/cactus-
generalize-fallback-definition-of-c/diff>.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1787>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1780: Correct name of Weinberg pseudotensor in QuasiLocalMeasures
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
Vassilios Mewes says:
[...] the Landau-Lifshitz quantities implemented in the QLM thorn, are not
actually using the Landau-Lifshitz pseudotensor, but rather the Weinberg's
pseudotensor, which he derived in his book General Relativity, Gravitation
and Cosmology.
I think it would be good to rename them accordingly, as it (at least for
me) caused some confusion when investigating those quantities.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1780>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1637: MoL should automatically allocate storage for sufficient timelevels of
evolved variables
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: MoL |
-------------------------+--------------------------------------------------
The MoL thorn requires that all evolved variables have at least two
timelevels of data, even if the integration method (e.g. RK4) does not
need any past timelevels. It uses one of these timelevels as scratch
space, potentially in addition to any other scratch space variables. In
the case where at least two timelevels are needed for other reasons, this
is more efficient than allocating an extra scratch space variable. Rather
than requiring the evolution thorn to allocate at least two timelevels of
storage for these variables, MoL should ensure sufficient timelevels via
the flesh API.
A related issue is that using timelevels for this purpose is wasteful in
situations where the timelevel is not used for any other purpose, since
the timelevel will be checkpointed even though it is only being used for
temporary storage.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1637>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1792: Pthreads: don't use PTHREADS_DIR to guess PTHREADS_INC_DIRS if PTHREADS_DIR
is NO_BUILD
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
this leads to inlcude dirs of the form NO_BUILD/include which makes no
sense.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1792>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit