#584: Use of uninitialized value in concatenation
------------------------+---------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
After failing to check out a thornlist (the current einsteintoolkit.th)
the automated build and test system re-runs GetComponents with --update.
On 27-Sep-2011, this gave the error:
{{{
Use of uninitialized value in concatenation (.) or string at
./GetComponents line 2514.
}}}
This line seems to be
{{{
$url = "(".$component{"URL"}.")|(".$component{"AUTH_URL"}.")";
}}}
Is the problem that SimFactory doesn't have an AUTH_URL?
I'm attaching the log of the testsuite script. I don't know if the error
is serious or not, since the checkout has already failed.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/584>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1689: Cactus should exit with a nonzero exit code if an error occurs
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
In WarnLevel.c, in CCTK_VWarn (called by CCTK_Warn), it says
if (level <= error_level)
{
CCTK_Abort (NULL, 0);
}
The second argument to CCTK_Abort is the exit code of the process. So if
there is an "error" warning, the process exits with 0 exit code; i.e.
success! This happens in several places in this file.
The user guide does not say anything about the exit code of Cactus. I
think that if Cactus has a level-0 warning, i.e. an error, then it should
exit with a non-zero exit code, and Erik agrees.
See
http://lists.einsteintoolkit.org/pipermail/users/2014-November/003878.html
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1689>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#702: Tests should use IO::out_fileinfo = "none"
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
The Cactus User Guide
(http://einsteintoolkit.org/documentation/UsersGuide/UsersGuidech9.html#x13-…)
recommends that test output files should always be the same, and hence use
IO::out_fileinfo = "none". I would like to implement this for the tests
in the ET, as it makes comparing test output using standard (non-Cactus
testsuite mechanism) diff tools possible.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/702>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1631: The dgfe branch for McLachlan generates NaNs
-----------------------------------------------------------+----------------
Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett
Type: defect | Status: new
Priority: optional | Milestone: ET_2014_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: dgfe,mclachlan,gamma driver |
-----------------------------------------------------------+----------------
When one uses the gamma driver formulation in the dgfe branch of McLachlan
and sets the shiftGammaCoefficient to zero, the runtime output has NaNs
because the code divides by zero.
A bit of flow control fixes this. Attached is a patch for the branch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1631>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1646: McLachlan does not give a reference for the gauge evolution equations
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: McLachlan |
-----------------------------------+----------------------------------------
McLachlan_BSSN.m does not seem to contain any information (eg in evolCalc)
that would tell me from which paper the different expressions for the
shift and lapse evolution expression are taken from (which may be useful
to understand what the different coefficients mean, since parsing the
multiple factors of the type XXXFactor * AAA + (1-XXXFactor) * BBB to get
either AAA or BBB is confusing).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1646>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1419: Cactus should produce no errors in Valgrind
-------------------------+--------------------------------------------------
Reporter: sbrandt | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: Cactus_4.3.0
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
Valgrind is a useful tool for identifying a large number of coding
problems. Currently, running Cactus under valgrind produces a large number
of spurious errors due to the implementation of the string library.
Attempts to use the valgrind suppression mechanism to eliminate them have
proven difficult.
However, these errors all go away if we simply replace all calls to
strdup() with calls to util_Strdup(), a function which is already part of
Cactus. Making this replacement shouldn't have any negative impacts, and
it would make valgrind more usable.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1419>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#706: External Library Support
-------------------------+--------------------------------------------------
Reporter: sbrandt | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: Cactus_4.1.0
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
We should remove support for all external library support that's wired
into the flesh (except maybe MPI) in favor of the newer more generic
mechanism.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/706>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#641: Parameter files and thornlists could be tested as part of the release
process
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2012_05
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
There are a number of parameter files and thornlists included as examples
with thorns in the ET, and in Cactus. Would it be feasible to have these
tested as part of the release process? For example, they should run
without crashing or missing thorns, should not trigger NaNs etc, and we
should minimise any warnings that are emitted. It would be nice to
automate this, though it probably requires a cluster, so would be distinct
from the usual test suite procedure, due to requiring more memory than
tests.
Something to think about for the next release.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/641>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1762: thorn lists in utils refer to old svn repositories
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2015_05
Component: Other | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
The thornlists in https://bitbucket.org/cactuscode/utilities.git refer to
the old Subversion repositories. This should be fixed before the next
release.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1762>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit