#1201: Incorrect dtshift in Exact with shift_add_{x,y,z} parameters
-----------------------------------+----------------------------------------
Reporter: barry.wardell | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The Exact thorn has shift_add_{x,y,z} parameters for adding a constant to
the shift. Considering these as a coordinate transformation using a vector
v^i = [shift_add_x, shift_add_y, shift_add_z], such a transformation
should affect both the shift and its time derivative. This is because the
time derivative in the new coordinates differs from the time derivative in
the old coordinates by a term v^j d(beta^i)/dx^j. This is correctly
implemented as a 4D coordinate transformation in the EinsteinExact thorns
and I have verified that the difference relative to the Exact thorn is
given by this missing term.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1201>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1097: Describe Tmunu in GRHydro
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Describe in GRHydro's documentation how Tmunu is defined
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1097>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#660: Make MHD multipatch-aware
-----------------------------------+----------------------------------------
Reporter: tbode | Owner: tbode
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
At least the Con2PrimM routines need to be multipatch-aware.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/660>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1690: The test system should treat a nonzero exit code from Cactus as a failure
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
The test system seems to ignore the fact that Cactus exits with a nonzero
exit code. It displays
Cactus exited with error code 1
Please check the logfile...
No files created in test directory
Success: 0 files identical
And in the summary at the end, it treats this as a passing test. In this
case, there were no test reference files and no files output, because the
test (by design) does not produce any data, it just aborts if the test
fails.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1690>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1523: Use Piraha to Parse all CCL files
-------------------------+--------------------------------------------------
Reporter: sbrandt | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone: Cactus_4.3.0
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
Piraha should be used to parse all the CCL files. This would give us a
well-defined grammar and the ability to let other tools use the CCL files
in a reliable way.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1523>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1949: provide floating branch to "current release" and links to it
-----------------------------+----------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version: development version
Keywords: EinsteinToolkit |
-----------------------------+----------------------------------------------
In order to not always have to update all websites with the correct ULRs
to the then current release it would be good if we were to provide a
"current release" branch of the ET which always points to the head of the
current release branch/tag. Ie right now it would be identical to 2016_05.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1949>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1658: ExternalLibraries/pciutils does not compile on Mac OS
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
When I try to compile ExternalLibraries/pciutils on Mac OS, I get
{{{
lspci.c:919:29: error: expected ')'
puts("lspci version " PCIUTILS_VERSION);
^
./pciutils.h:18:26: note: expanded from macro 'PCIUTILS_VERSION'
#define PCIUTILS_VERSION PCILIB_VERSION
^
lspci.c:919:11: note: to match this '('
puts("lspci version " PCIUTILS_VERSION);
}}}
This is with the osx-mountain-lion-macports-gcc.cfg optionlist, and "gcc-
mp-4.6 (MacPorts gcc46 4.6.4_3) 4.6.4".
I have to disable this thorn in my thornlist (or machine definition file)
to compile the ET. This means that the ET will not compile out of the box
on Mac OS.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1658>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1934: pciutils was broken
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
ExternalLibraries/pciutils was broken; the configure.sh script references
two patch files that were not there. I reverted the commit.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1934>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1906: CarpetRegrid2: possible off-by-one error when using regrid_every parameter
---------------------------+------------------------------------------------
Reporter: bmundim | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: Carpet | Version: development version
Keywords: CarpetRegrid2 |
---------------------------+------------------------------------------------
I was working on a par file for a quick regridding test and found out an
unexpected behaviour regarding regridding. Basically I want a par file
with a few iterations such that it adds a refinement level every 4
iterations for example. I set the following parameters then:
{{{
CarpetRegrid2::add_levels_automatically = "yes"
CarpetRegrid2::regrid_every = 4
}}}
for a grid structure as such:
{{{
Cactus::cctk_itlast = 10
CoordBase::xmin = -0.5
CoordBase::ymin = -0.5
CoordBase::zmin = -0.5
CoordBase::xmax = 0.5
CoordBase::ymax = 0.5
CoordBase::zmax = 0.5
CoordBase::ncells_x = 16
CoordBase::ncells_y = 16
CoordBase::ncells_z = 16
Carpet::max_refinement_levels = 3
CarpetRegrid2::num_centres = 1
CarpetRegrid2::active_1 = "yes"
CarpetRegrid2::num_levels_1 = 1
CarpetRegrid2::radius_1[1] = 0.12
CarpetRegrid2::radius_1[2] = 0.04
}}}
I was expecting then regridding to happen at iterations 4 and 8, however
if you run the attached par file, a modification of balsara shocktube
test, you see that the level additions actually happen at iterations 5 and
9 instead:
{{{
...
INFO (CarpetRegrid2): Increasing number of levels of centre 1 to 2 (it=5)
...
INFO (CarpetRegrid2): Increasing number of levels of centre 1 to 3 (it=9)
}}}
which is apparently an off-by-one kind of error. I tracked down the code
producing these messages and it comes from function
CarpetRegrid2_RegridMaps at CarpetRegrid2/src/regrid.cc, lines 745 to 747.
In order for that piece of code to execute we do have to have do_recompose
set to true. Strangely the condition to set it, compares the previous
iteration to the regrid_every parameter on line 707 of the same file:
{{{
(cctk_iteration - 1) % regrid_every == 0
}}}
Investigating if this actually makes sense I was led to what I think it
might be the source of the problem on line 58 of Carpet/src/Evolve.cc.
Time and iteration is advanced before calling CallRegrid. Skimming over
the AdvanceTime routine it is not clear to me that it really needs to be
called before CallRegrid. If it is really needed then why the condition to
regrid or not is not taken on the current updated iteration as in:
{{{
cctk_iteration % regrid_every == 0
}}}
Thanks,
Bruno
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1906>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit