#583: PITTNullCode lacks test case outputs
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The PITTNullCode arrangement has several test parameter files without
associated output.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/583>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1986: this compared to NULL in CarpetLib
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: Carpet | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
I get
{{{
/home/rhaas/Cactus/arrangements/Carpet/CarpetLib/src/gdata.cc: In member
function ‘void gdata::copy_from(comm_state&, const gdata*, const ibbox&,
const ibbox&, const islab*, int, int)’:
/home/rhaas/Cactus/arrangements/Carpet/CarpetLib/src/gdata.cc:185:53:
warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
int const order_space = (this ? cent : src->cent) == vertex_centered ?
1 : 0;
~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
}}}
which leads me to suspect that the compiler is allowed to assume this !=
NULL and will optimize out one half of the condition.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1986>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1821: Carpet may call object methods with this == NULL
----------------------+-----------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: optional | Milestone:
Component: Carpet | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
see pull request https://bitbucket.org/eschnett/carpet/pull-requests/7
/carpet-avoid-using-null-pointer-for-member/diff
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1821>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1674: Switch to OpenBLAS
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Other | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
OpenBLAS is a BLAS and LAPACK library that is significantly more efficient
that the standard ("reference") BLAS. I suggest we switch the ET thorn
list to ExternalLibraries/OpenBLAS instead of ExternalLibraries/BLAS and
ExternalLibraris/LAPACK.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1674>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1875: SetMask_SphericalSurface: retain mask
------------------------------------+---------------------------------------
Reporter: cott@… | Owner:
Type: enhancement | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
------------------------------------+---------------------------------------
SetMask_SphericalSurface sets a mask based on SphericalSurface
information. At every invocation, it wipes the mask, then resets it. Old
behavior: mask is set from surface only if surface is active and valid.
However, sometimes finding a horizon with AHFinderDirect may fail, but the
mask info (i.e. the radius) may be perfectly valid. Mask is still not set
in the old behavior, because AHFinderDirect makes the mask invalid (-1) if
it does not find a horizon. New behavior: set mask from surface is surface
is active and its minimum radius is > 0.
Pull request: https://bitbucket.org/einsteintoolkit/einsteinutils/pull-
requests/1/setmask_sphericalsurface-retain-mask/diff
Pull request also adds verbose output (default: off).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1875>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1390: parameter file parser aborts when findeing first error
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
The attached parfile contains multiple errors (one per line).
However the parameter file parser only reports the first one, then stops.
This makes verifying parfiles for correctness hard. It might be good to
defer aborting until the end of the file or until a larger number of
parsing errors were encountered.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1390>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1172: Remove unnecessary exp/log calls in EOS_Omni
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
EOS_Omni seems to call exp/log more often than necessary in the nuc_eos
table lookup routines. Use algebraic identities to remove them.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1172>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#2003: piraha_everywhere Zelmani stress test
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version: development version
Keywords: piraha |
--------------------+-------------------------------------------------------
Hello all,
Zelmani contains a number of ccl files that make the perl based piraha
parser abort with errors but that parsed fine with the old parrser. Some
ccl files are clearly incorrect while others are correct and the parser
should accept them. The major such issue is that the parser requires that
that there is a private/public/protected setting at the beginning of a
param.ccl which is not required by the docs since parameters are supposed
to default to private.
I attach all ccl files both in their original version as well as version
that can be parsed without errors (hopefully).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2003>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1916: GetComponents checks out git repositories serially
---------------------------+------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2016_11
Component: GetComponents | Version: development version
Keywords: |
---------------------------+------------------------------------------------
When called with --parallel, GetComponents still checks out git
repositories serially. This may have been introduced with #83, but there
is no information in that ticket about what was done.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1916>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#614: relative tolerence in test.ccl of QuasiLocalMeasures very high
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: optional | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
LSUThorns/QuasiLocalMeasures/test/test.ccl curerntly reads:
{{{
ABSTOL 1.e-7
RELTOL 1.e+5
}}}
I am curious: is the relative tolerance of 10,000 intentional or should it
have been 1e-5 instead?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/614>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit