#2043: new thorn for initial data (Hydro_RNS)
Reporter: Roberto De Pietri
Status: resolved
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: Other
Changes (by Roland Haas):
status: resolved (was new)
The LSU and Parma groups used for publications and contributed to the development of the thorn the generate initial data for Rotating-Neutron-Star RNS based on Nik Stergioulas code (http://www.gravity.phys.uwm.edu/rns/) which constructs models of rapidly rotating, relativistic, compact stars using tabulated equations of state which are supplied by the user or polytqopic EOS. The code
was widely used in conjunction with the Whisky code and more recently with GRHydro.
The relevant code can be found here:
[https://bitbucket.org/GravityPR/prthorns/src]
I'd like another developer to have a look and give input. Once/If this is deemed ok to be included on technical grounds, we will add the necessary documentation. Test suites and example are already present.
**Keyword:** parma
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2043/new-thorn-for-ini…
#2469: None of the thorns in WVUThorns_Diagnostics have documentation
Reporter: Roland Haas
Status: new
Milestone: ET_2021_05
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Is there progress on documentation for the remaining 3 thorns:
* particle\_tracerET
* Seed\_Magnetic\_Fields\_BNS
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2469/none-of-the-thorn…
#2551: include RePriMand in the ET
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Wolfgang Kastaun):
I’ve been collecting commits in the development repo \(In the public repo I’d like a condensed history meaningful to users\), including the tex documentation from the pull request. I’ll push to public today.
I also went through the review comments \(very useful, thanks again\). I have commented inside the pull request on some concerns that are non-issues as far as I can tell. The rest will be addressed in today's push. Due to time constraints, for the time being I will not fix all the error messages that should include the offending numbers in the message. This will probably go in the next release, which will also provide a TOV solver. Hope this is ok for the current ET release.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2551/include-reprimand…
#1738: Update requirements documentation for Cactus
Reporter: Ian Hinder
Status: resolved
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: Cactus
Changes (by Roland Haas):
status: resolved (was open)
The Cactus User Guide has a section "Required software" which lists the software needed for Cactus. I think this should list the various language versions which are needed. For example, we could say (if this is the case) that Cactus requires C99 and C++98 or later. The page probably also should be updated to replace SVN with Git.
**Keyword:** documentation
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1738/update-requiremen…
#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
@{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} maybe revisit this for piraha?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Changes (by Roland Haas):
assignee: Steven R. Brandt (was )
responsible: [] (was )
The test case in CactusTest/TestPar fails because inf is not recognised as number.
**Keyword:**
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#2512: Enable detection of `attribute(pure)`
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: proposal
Priority: minor
Component: Cactus
Comment (by Roland Haas):
I will re-enable `CCTK_ATTRIBUTE_PURE` shortly after the 2021\_11 release so that we can test if this breaks anything.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2512/enable-detection-…
#2572: Build failure in PITTNullCode SphericalHarmonicReconGen
Reporter: Wolfgang Kastaun
Status: invalid
Milestone:
Version: ET_2021_05
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
status: invalid (was open)
Comment (by Roland Haas):
Cannot reproduce due to lack of arch Linux. Seems to be an issue in the Linux/GNU distro and not in the ET.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2572/build-failure-in-…
#2571: runtime failure due to useing character*8 in DECLARE_CCTK_ARGUMENTS_CHECKED macro
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: Cactus
Changes (by Roland Haas):
assignee: Roland Haas (was )
responsible: [] (was )
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2571/runtime-failure-d…
#2571: runtime failure due to useing character*8 in DECLARE_CCTK_ARGUMENTS_CHECKED macro
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: Cactus
Comment (by Roland Haas):
Please review.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2571/runtime-failure-d…
#2551: include RePriMand in the ET
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
The deep freeze for the release is going to be very soon. The documentation should go into `public` as soon as possible. Please also take a look at the review comments.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2551/include-reprimand…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Gabriele Bozzola):
It’s the opposite: it is the con2prim that does non-con2prim things. My workaround to achieve what I want is to change \`Tmunubase\`
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Part of the issue may be that ILGRMHD’s Tmunu code actually does non-Tmunu things namely con2prim as far as I remember. So not scheduling the Tmunu routines is not possible.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Gabriele Bozzola):
Upon further inspection, the PR does not solve the problem. The group `SetTmunu` is not added to the scheduler when `TmunuBase::stress_energy_at_RHS = "no"`
I don’t know how to fix this in a clean and easy way. The scheduler looks like this
```
GROUP HydroBase_Con2Prim: Convert from conservative to primitive variables
GROUP SetTmunu: Group for calculating the stress-energy tensor
TmunuBase::TmunuBase_ZeroTmunu: Initialise the stress-energy tensor to zero
GROUP AddToTmunu: Add to the stress-energy tensor here
IllinoisGRMHD::IllinoisGRMHD_conserv_to_prims: Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder.
IllinoisGRMHD::IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz: Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velocities pointed inward from outer boundary are set to zero.
```
`IllinoisGRMHD` computes Tmunu when it is doing primitive-recovery \(in `IllinoisGRMHD_convser_to_prims`\), so, it has to be scheduled after `TmunuBase_ZeroTmunu`. However, the group `SetTmunu` does not exist at all when \``TmunuBase::stress_energy_at_RHS = "no"`
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2576: `after` statements in scheduler in `IllinoisGRMHD`
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Non existent functions in an `AFTER` or `BEFORE` \(and also `IN`\) clause in `schedule.ccl` are allowed in Cactus.They can for example be defined by thorns that are not included in the thornlist \(and may be private\). Eg `BSSN_RegisterVars` may be of that type. However your list also contains some that would seem to be in IllinoisGRMHD itself so their exclusion looks like a bug to me.
Assigning to the ILGRMHD author \(and maintainer\) @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278}
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2576/after-statements-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Gabriele Bozzola):
A opened a PR \([https://bitbucket.org/zach\_etienne/wvuthorns/pull-requests/8/fix-2497](https://bitbucket.org/zach_etienne/wvuthorns/pull-requests/8/fix-2497)\) which should fix this problem.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2576: `after` statements in scheduler in `IllinoisGRMHD`
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
In fixing #2497, I found that several `after` statements in the `schedule.ccl` of `IllinoisGRMHD` \(but probably also `GiRaFFE`\) are ill-defined \(or I don't know how the scheduler works\). In particular, according to `grep`, the following groups do not exist in the `Einstein Toolkit`:
* `BSSN_RegisterVars`
* `lapse_RegisterVars`
* `Lapse_InitSymBound`
* `empostid`
* `lapsepostid`
* `p2c`
* `bssn_rhs`
* `shift_rhs`
* `compute_B_postrestrict`
* `mhd_conserv2prims_postrestrict`
* `outer_boundaries_on_A_mu` \(probably this one should be `IllinoisGRMHD_outer_boundaries_on_A_mu`\)
* `compute_B_and_Bstagger_from_A` \(probably this one should be `IllinoisGRMHD_compute_B_and_Bstagger_from_A`\)
In addition to this:
* `IllinoisGRMHD_compute_B_and_Bstagger_from_A` is scheduled in `HydroBase_Boundaries`, but then `IllinoisGRMHD_conserv_to_prims` to be after `compute_B_and_Bstagger_from_A`, but it is scheduled in another group \(originally `AddToTmunu`, but with my fix it is `SetTmunu`\), so I am not sure what’s the use of that `after`
* `IllinoisGRMHD` does not define `READ/WRITE` statements
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2576/after-statements-…
#2575: online thorn documentation only lists thorns active in thorn list
Reporter: Roland Haas
Status: new
Milestone: ET_2021_11
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit website
The online thorn documentation at [https://www.einsteintoolkit.org/documentation/ThornGuide.php](https://www.e… only shows thorns that are enabled in the full thornlist \([einsteintoolkit.th](http://einsteintoolkit.th)\) which misses thorns that are part of the Einstein Toolkit but not enabled by default \(eg LORENE2, RePrimAnd\).
The script that builds the documentation should be extended to build documentation for all thorns in arrangements rather than only those on the thornlist.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2575/online-thorn-docu…