Trac August 2022

trac@lists.einsteintoolkit.org

1 participants
121 discussions

#2619: include Ellipitca (reader) in Einstein Toolkit
by Roland Haas 02 Aug '22

02 Aug '22

#2619: include Ellipitca (reader) in Einstein Toolkit Reporter: Roland Haas Status: open Milestone: Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): @{5e8f32efacb63e0b834ed007} agreed to review this. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…

1 0

#2616: Add NRPyEllipticET to the Einstein Toolkit
by Roland Haas 02 Aug '22

02 Aug '22

#2616: Add NRPyEllipticET to the Einstein Toolkit Reporter: Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): Cheng-Hsin Cheng agreed to review this. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2616/add-nrpyelliptice…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Gabriele Bozzola 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Gabriele Bozzola): I added `SphericalSurface_HasBeenSet`, however I think that the correct fix should be to substitute \``SphericalSurface_HasBeenSet`\` to `SphericalSurface_Setup`. My impression is that the group `SphericalSurface_HasBeenSet` is there exactly as a placeholder to ensure that spherical surfaces exist. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Gabriele Bozzola 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Gabriele Bozzola): [https://bitbucket.org/eschnett/carpet/pull-requests/52/reduce-schedule-mask… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Roland Haas 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): yup. Might even be that one should change `SphericalSurface_Setup`to `SphericalSurface_Set` in case `SphericalSurface_Setup` does not actually initialize `sf_info` \(and thus scheduling relative it it is pointless\). That would be future enhancement though \(and needs some more checking for possible unanticipated side effects first\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Gabriele Bozzola 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Gabriele Bozzola): The function in `CarpetMask` are scheduled in `SetupIMask`, which is a group provided by `CarpetReduce.` If I look at the `schedule.ccl` of `CarpetReduce`, I see ``` SCHEDULE GROUP MaskBase_SetupMask AT basegrid AFTER (SpatialCoordinates SphericalSurface_Setup) ``` Is the correct fix to add `Spherical_Surface_Set` \(or `SphericalSurface_HasBeenSet`\) among the AFTER here? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Roland Haas 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Roland Haas 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): responsible: [] (was ) assignee: Roland Haas (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Roland Haas 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Can you create a pull request \(for CarpetMask\) to fix the schedule? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Gabriele Bozzola 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Gabriele Bozzola): `CarpetMask` wants `sf_info` from `SphericalSurface`, which is initially not available. Looking at the scheduler, I can see why this is happening \(relevant section\): ``` GROUP MaskBase_SetupMask: Set up the weight function GROUP MaskBase_SetupMaskAll: Set up the weight function CarpetReduce::MaskBase_AllocateMask: [global] Allocate the weight function CarpetReduce::MaskBase_InitMask: [global] [loop-local] Initialise the weight function GROUP SetupIMaskInternal: Set up the integer weight function (schedule other routines in here) CarpetReduce::CoordBase_SetupMask: [global] [loop-local] Set up the outer boundaries of the weight function CarpetReduce::CarpetMaskSetup: [global] [loop-singlemap] Set up the weight function for the restriction regions GROUP SetupIMask: Set up the integer weight function (schedule other routines in here) CarpetMask::CarpetExcludedSetup: [global] [loop-local] Set up the weight function for the excluded regions CarpetMask::CarpetSurfaceSetup: [global] [loop-local] Set up the weight function for the excluded spherical surfaces CarpetReduce::MaskBase_SetMask: [global] [loop-local] Set the weight function GROUP SetupMask: Set up the real weight function (schedule other routines in here) CarpetReduce::MaskBase_TestMask: [global] Test the weight function SphericalSurface::SphericalSurface_Set: [global] Set surface radii to be used for initial setup in other thorns GROUP SphericalSurface_HasBeenSet: Set the spherical surfaces before this group, and use it afterwards SphericalSurface::SphericalSurface_CheckState: [global] Test the state of the spherical surfaces ``` `CarpetMask` is scheduled before `SphericalSurface_Set`, which is what sets `sf_info`. This is in the `BASEGRID` bin. As a result, masks are possibly not correctly set at iteration 0, and the run fails when presync is set to `mixed-error`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac August 2022