Trac January 2023

trac@lists.einsteintoolkit.org

1 participants
91 discussions

#2686: Rename CCTK_REAL -> double when float is not tested
by Erik Schnetter 26 Jan '23

26 Jan '23

#2686: Rename CCTK_REAL -> double when float is not tested Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Erik Schnetter): See [https://en.cppreference.com/w/c/numeric/tgmath](https://en.cppreference.com… for C. \(Fortran and C\+\+ already support this generic functionality.\) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-…

1 0

#2686: Rename CCTK_REAL -> double when float is not tested
by Zach Etienne 26 Jan '23

26 Jan '23

#2686: Rename CCTK_REAL -> double when float is not tested Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Zach Etienne): Roland pointed out during today’s call that the compile flag REAL\_PRECISION can be set to 4, 8, or 16 bytes. It’s likely this directly sets CCTK\_REAL. Also if we would truly like a say, physics thorn, to be cross-compatible with different CCTK\_REAL aliases, we’d probably also need aliases for transcendental functions so that e.g., CCTK\_SIN\(x\) would alias to sin\(x\) for `double` , sinf\(x\) for `float` , and sinl\(x\) for `long double`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-…

1 0

#2666: Testsuite system does not recognize "Cactus" thorn
by Roland Haas 26 Jan '23

26 Jan '23

#2666: Testsuite system does not recognize "Cactus" thorn Reporter: Roland Haas Status: new Milestone: Version: development version Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Unless objected I will apply this after 2023-02-09. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2666/testsuite-system-…

1 0

#2686: Rename CCTK_REAL -> double when float is not tested
by Zach Etienne 25 Jan '23

25 Jan '23

#2686: Rename CCTK_REAL -> double when float is not tested Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Zach Etienne): I like the idea of testing all the commonly used thorns with single precision, but I worry it’s going to take a long time to debug and fix all the issues. \(I’d love to be proven wrong!\) Compiler errors are just the start I fear; consider all the algorithms with tolerances tuned to relative errors ~1e-15 like conservatives-to primitives solvers, AH finders, etc. Also I bet our more complex finite-difference-based and possibly finite-volume-based codes \(BSSN & GRMHD codes\) will become unstable & unusable. But again, I’d love to be proven wrong. :slight_smile: -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-…

1 0

#2686: Rename CCTK_REAL -> double when float is not tested
by Erik Schnetter 25 Jan '23

25 Jan '23

#2686: Rename CCTK_REAL -> double when float is not tested Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Erik Schnetter): I’m not convinced they would break. I assume that many of them would switch to double precision for intermediate calculations, but they wouldn’t per se break. And if they break then it’s usually just a compile-time error that is straightforward to correct, such as e.g. calling `max(x, 1.0)` in C\+\+. In fact, I am going to propose that we should build the commonly used thorns with single precision and correct these compiler errors. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-…

1 0

#2686: Rename CCTK_REAL -> double when float is not tested
by Zach Etienne 25 Jan '23

25 Jan '23

#2686: Rename CCTK_REAL -> double when float is not tested Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Zach Etienne): Thanks for the insights, Erik. It’s great to know that the core infrastructure correctly handles `float`. Indeed the problem lies with the many, many physics modules that – in all likelihood – have never been run with `float`. Most if not all of these could/should have `CCTK_REAL` replaced with `double` , as setting `CCTK_REAL` to `float` would break them. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-…

1 0

#2686: Rename CCTK_REAL -> double when float is not tested
by Erik Schnetter 25 Jan '23

25 Jan '23

#2686: Rename CCTK_REAL -> double when float is not tested Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Erik Schnetter): Many thorns work and have been tested, in particular all thorns in the CactusBase, CactusPUGH, CactusPUGHIO, Carpet, and many in the CarpetX arrangements. Most of the basic infrastructure thorns work, but many of the physics thorns won’t. Unit tests don’t specify the precision of `CCTK_REAL`, that’s a build-time choice. We could run unit tests in single precision, but I’m afraid many would fail simply because single precision has a different accuracy. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-…

1 0

#2686: Rename CCTK_REAL -> double when float is not tested
by Zach Etienne 25 Jan '23

25 Jan '23

#2686: Rename CCTK_REAL -> double when float is not tested Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Here's an idea: Virtually no thorns have been tested with CCTK\_REAL -> float \(single precision\), and in fact many are _guaranteed_ to break. How about for all thorns that have no unit tests in which CCTK\_REAL -> float, we do a regex replace CCTK\_REAL -> double? Bottom line: If CCTK\_REAL looks like a double, swims like a double, and quacks like a double, let's call it a double. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-…

1 0

#2685: credentials are not taken from ORCID
by Steven R. Brandt 18 Jan '23

18 Jan '23

#2685: credentials are not taken from ORCID Reporter: Status: new Milestone: Version: Type: task Priority: trivial Component: Comment (by Steven R. Brandt): I believe this was resolved when the user updated their profile and made their email public. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2685/credentials-are-n…

1 0

#2679: How to link an externally compiled library during ET compilation
by Roland Haas 18 Jan '23

18 Jan '23

#2679: How to link an externally compiled library during ET compilation Reporter: Maria Mutz Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): Sorry, I forgot to respond to this. Looking at the `make.code.defn` file I do not understand why it even would ever try to compile `include_modulefiles_MRNS.f90` at all since it is not even listed in the SRCS line. So I am very confused. Is there any chance that I could get to see the whole source code? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2679/how-to-link-an-ex…

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac January 2023