Trac October 2023

trac@lists.einsteintoolkit.org

1 participants
53 discussions

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 19 Oct '23

19 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): The complete set of ID contains three files: 1. BNSdata\_properties.txt - sgrid configuration summary 2. checkpoint.0 - main file with ID 3. sgrid\_id.par - sgrid parfile All of them are required to be there. The only thing you need for Cactus to run \(of for the test\) is a path to the directory where all there are located. It is one line you mentioned before: ``` DNSdata::sgrid_datadir = "../../../arrangements/CactusSgrid/DNSdata/test/sgrid_id" ``` The file ``` "../../../arrangements/CactusSgrid/DNSdata/test/sgrid_id/sgrid_id.par" ``` is not Cactus parfile. It is sgrid parfile and simply must be there. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 19 Oct '23

19 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Oh, sorry. I didn’t see your message before commenting. I’m not sure I understand. Are you talking about the parfile in test/sgrid\_id? How exactly does it interact with the test parfile? Do users normally have to run 2 different parfiles to use the thorn? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 19 Oct '23

19 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Right. I forgot to change it back. Will be done in 10 min. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 19 Oct '23

19 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): The test is failing because if failed to find the BNS\_properties.txt file. It looks like you hard-coded the path for the file to something on your machine. Can you try switching it to the `../../../arrangements/CactusSgrid/DNSdata/test/sgrid_id`? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2749: WVUThorns: sprintf use violates standard
by Leonardo Werneck 19 Oct '23

19 Oct '23

#2749: WVUThorns: sprintf use violates standard Reporter: Erik Schnetter Status: resolved Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Changes (by Leonardo Werneck): status: resolved (was new) Comment (by Leonardo Werneck): This issue was addressed in commit [72342fa](https://bitbucket.org/zach_etienne/wvuthorns_diagnostics/commits/7…. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2749/wvuthorns-sprintf…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 19 Oct '23

19 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): I pushed a new .par file and the test works well. There is an issue to discuss. The thorn reads the Sgrid ID, does the job, and leaves the data stored to be used again \(for the sake of efficiency, to not repeat this "job"\). Is it ok? We can write it that way and remove this data immediately, but it is not going to change the fact, that before Cactus can take the data they have to be \(temporarily or not\) written. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Roland Haas 17 Oct '23

17 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): The test counts as “passed” if there are no output files provided and the code exits cleanly \(exit code 0\). having some output can of course be useful to diagnose what failed \(and also that the numbers are correct\). Eg if the ID reader puts the metric where the curvature is expected that likely still gives exit code 0 but is of course completely wrong. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 17 Oct '23

17 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): That works for me. Once the test is properly set up, it should be easy to tell if its working or not since the CI banner at the top of the website will be passing \(green\), pending \(yellow\), or failing \(red\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 17 Oct '23

17 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Right... Documentation... Let me think... What about Monday? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 17 Oct '23

17 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): That’s fine. Also, don’t forget to add documentation. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac October 2023