Trac March 2024

trac@lists.einsteintoolkit.org

1 participants
60 discussions

#2783: MoL: Avoid empty array
by Roland Haas 06 Mar '24

06 Mar '24

#2783: MoL: Avoid empty array Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): I’d add a comment describing this to the code, otherwise a future reader may wonder why the size of 1 is needed or put the whole block into a `if(nsrsc > 0) {...}` block which makes the reason explicit in code but is a larger and possibly hard to do \(if the extra scope causes issues\) change. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2783/mol-avoid-empty-a…

1 0

#2782: GRHayLib fails to compile on testing server with 'max_lorenz_factor' undeclared
by Roland Haas 06 Mar '24

06 Mar '24

#2782: GRHayLib fails to compile on testing server with 'max_lorenz_factor' undeclared Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): title: GRHayLib fails to compile on testing server with 'max_lorenz_factor' undeclared (was GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2782/grhaylib-fails-to…

1 0

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared
by Roland Haas 06 Mar '24

06 Mar '24

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Test of trac header encoding, please ignore. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2782/grhaylib-fails-to…

1 0

#2783: MoL: Avoid empty array
by Erik Schnetter 06 Mar '24

06 Mar '24

#2783: MoL: Avoid empty array Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Automatic C arrays cannot be empty. Use a size-1 array instead if necessary. See [https://bitbucket.org/cactuscode/cactusnumerical/pull-requests/21](https://… Found by enabling run-time compiler checks in debug mode. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2783/mol-avoid-empty-a…

1 0

#2781: Fix bug in debug mode with presync_mode = "off"
by Roland Haas 06 Mar '24

06 Mar '24

#2781: Fix bug in debug mode with presync_mode = "off" Reporter: Samuel Cupp Status: open Milestone: ET_2024_05 Version: Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Are there any updates on this? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2781/fix-bug-in-debug-…

1 0

#2781: Fix bug in debug mode with presync_mode = "off"
by Roland Haas 06 Mar '24

06 Mar '24

#2781: Fix bug in debug mode with presync_mode = "off" Reporter: Samuel Cupp Status: open Milestone: ET_2024_05 Version: Type: bug Priority: major Component: Cactus Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2781/fix-bug-in-debug-…

1 0

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared
by Roland Haas 06 Mar '24

06 Mar '24

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2782/grhaylib-fails-to…

1 0

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared
by Roland Haas 05 Mar '24

05 Mar '24

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): hmm, this has been fixed around git hash [ee70afd](https://github.com/GRHayL/GRHayL/commits/ee70afd0c49bdde1cc65ec077… "Fixed Lorenz->Lorentz in parameter name" of [GRHayL](https://github.com/GRHayL/GRHayL) and git hash [fbb3d00](https://github.com/GRHayL/GRHayL/commits/fbb3d00ef4bc65f2e5728100f… "CI: fixed compilation error" of [GRHayL](https://github.com/GRHayL/GRHayL) or so, yes? Those claim be couple of days old, but maybe “commit” and “push” here are different. I’ll trigger a CI build. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2782/grhaylib-fails-to…

1 0

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared
by Samuel Cupp 05 Mar '24

05 Mar '24

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} I pushed a fix that should resolve that. I don’t know what the CI schedule is on, but please let me know if it fails again. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2782/grhaylib-fails-to…

1 0

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared
by Roland Haas 05 Mar '24

05 Mar '24

#2782: GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn On the CI testing server building the ET fails with: ``` -05T00:10:22.0014094Z Checking status of thorn GRHayLib 2024-03-05T00:10:22.1750005Z COMPILING GRHayL/GRHayLib/src/initialize_and_shutdown.c 2024-03-05T00:10:22.2282841Z /home/runner/work/tests/tests/master/configs/sim/build/GRHayLib/initialize_and_shutdown.c: In function ‘GRHayLib_initialize’: 2024-03-05T00:10:22.2286561Z /home/runner/work/tests/tests/master/configs/sim/build/GRHayLib/initialize_and_shutdown.c:165:7: error: ‘max_lorenz_factor’ undeclared (first use in this function); did you mean ‘max_Lorentz_factor’? 2024-03-05T00:10:22.2288608Z 165 | max_lorenz_factor, Lorenz_damping_factor, 2024-03-05T00:10:22.2289476Z | ^~~~~~~~~~~~~~~~~ 2024-03-05T00:10:22.2290397Z | max_Lorentz_factor 2024-03-05T00:10:22.2292076Z /home/runner/work/tests/tests/master/configs/sim/build/GRHayLib/initialize_and_shutdown.c:165:7: note: each undeclared identifier is reported only once for each function it appears in 2024-03-05T00:10:22.2324428Z make[3]: *** [/home/runner/work/tests/tests/master/configs/sim/config-data/make.config.rules:267: initialize_and_shutdown.c.o] Error 1 2024-03-05T00:10:22.2327122Z make[2]: *** [/home/runner/work/tests/tests/master/lib/make/make.thornlib:113: make.checked] Error 2 2024-03-05T00:10:22.2332236Z make[1]: *** [/home/runner/work/tests/tests/master/lib/make/make.configuration:179: /home/runner/work/tests/tests/master/configs/sim/lib/libthorn_GRHayLib.a] Error 2 ``` See full log at [https://github.com/EinsteinToolkit/tests/actions/runs/8148610359/job/222717… This does not seem to happen on my workstation. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2782/grhaylib-fails-to…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac March 2024