#2871: EOS_Omni's nuceos code used int to hold hid_t values
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Hmm, maybe clarification: the code snippet shown in the description is the old code, the proposed change uses `long long int _error_code = (fn_call);` \(actually fails to compile without, with an error ““\).
I’ll add the `do { } while (0)` trick.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2871/eos_omnis-nuceos-…
#2871: EOS_Omni's nuceos code used int to hold hid_t values
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Erik Schnetter):
I recommend two further changes for safety:
* Add parentheses around `fn_call`
* Add a `do { } while (0)` construct around the current `if` construct. I’m not sure whether the current `if` construct is working as expected if it is followed directly by an `else` keyword.
Approved.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2871/eos_omnis-nuceos-…
#2871: EOS_Omni's nuceos code used int to hold hid_t values
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Please review.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2871/eos_omnis-nuceos-…
#2879: PETSc: update tarball to 3.23.4
Reporter: Roland Haas
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
status: open (was new)
Comment (by Roland Haas):
Please review
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2879/petsc-update-tarb…
#2875: handle system directories when looking for (extra) hdf5 libraries
Reporter: Roland Haas
Status: open
Milestone: ET_2025_05
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Thank you.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2875/handle-system-dir…