#2739: change ADMMacros::spatial_order to GRHydro::sources_spatial_order in Hydro_RNSID example parfiles
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: EinsteinToolkit thorn
@{557058:3bd8b315-5aeb-4783-8a43-0585fee09596} reported [https://lists.einsteintoolkit.org/pipermail/users/2023-June/008942.html](ht… that the example parameter files still contains use of `ADMMacros::spatial_order` which `GRHydro` no longer uses and has been replaced in `GRHydro` by `GRHydro::sources_spatial_order`.
Since ADMMacros is deprecated these should be removed from the par files.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2739/change-admmacros-…
#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic"
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
@{557058:65c5f18c-c3ad-4126-bb2b-be0e766b31ef} @{557058:a2800088-fc6e-4fbe-9a1e-663271f736bd} some more details. The Einstein Toolkit tests still all pass in test run 682 on [https://einsteintoolkit.github.io/tests/](https://einsteintoolkit.github.io… then first fail in run 683 [https://einsteintoolkit.github.io/tests/build\_683.html](https://einsteinto… .
The HTML page shows a list of changes that happened to the full ET repositories since the last run \(ie from 682 to 683\). Most of them are for nrpytutorial so unlikely to affect anything in Canuda or Lean\_public. The last recorded change though in LeanBSSLMoL and reports on the changes in git commits [0faaf83](https://bitbucket.org/einsteintoolkit/tickets/commits/0faaf83)..[7… of lean\_public \(you can see them using `git log 0faaf83..7457e18` in your checkout\):
> updated submodules
> Submodule repos/lean\_public [0faaf83](https://bitbucket.org/einsteintoolkit/tickets/commits/0faaf83)..[7…:
>
> LeanBSSNMoL: remove parameter eta\_beta\_dynamic from test parameter files
> NPScalars \[schedule.ccl\]: fix scheduling of CalcNPScalars
> LeanBSSNMoL: remove unused parameters eta\_beta\_dynamic and moving\_eta\_transition
> LeanBSSNMoL \[schedule.ccl\]: remove sync call in LeanBSSN\_adm2bssn
> LeanBSSNMoL \[schedule.ccl\]: make sure that ApplyBCs at CCTK\_INITIAL is only called after Boundary\_SelectGroupForBC are set
The HTML page contains links to the log files for each failing test in the “Failed Tests and Changes” table. Eg. [https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version\_683… for the failing “teukolsky” test in NPScalars.
The teukolsky test seems to run without error message and then fails due to too large differences \(see the diff link in the table that shows the diff file that the Cactus test system produces: [https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version\_683… \)
The others seem to fail with a parameter file error \(visible in their log files\):
```
[1mWARNING[L1,P0] (Cactus):[0m Major error in parameter file '/home/runner/simulations/TestJob01_temp_2/output-0000/arrangements/Scalar/TwoPunctures_BBHSF/test/SF_twopuncturesID_test.par' line 166: Parameter 'LeanBSSNMoL::eta_beta_dynamic' not found
[1mWARNING level 0 from host fv-az357-438.xjukslrwoije1kgjy1zwota3vf.cx.internal.cloudapp.net process 0
in thorn Cactus, file /home/runner/work/tests/tests/master/configs/sim/build/Cactus/main/ProcessParameterDatabase.c:201:
->[0m CCTKi_SetParameterSetMask: 1 major error in parameter file
WARNING[L1,P0] (Cactus): Major error in parameter file '/home/runner/simulations/TestJob01_temp_2/output-0000/arrangements/Scalar/TwoPunctures_BBHSF/test/SF_twopuncturesID_test.par' line 166: Parameter 'LeanBSSNMoL::eta_beta_dynamic' not found
WARNING level 0 from host fv-az357-438.xjukslrwoije1kgjy1zwota3vf.cx.internal.cloudapp.net process 0
in thorn Cactus, file /home/runner/work/tests/tests/master/configs/sim/build/Cactus/main/ProcessParameterDatabase.c:201:
-> CCTKi_SetParameterSetMask: 1 major error in parameter file
WARNING[L1,P1] (Cactus): Major error in parameter file '/home/runner/simulations/TestJob01_temp_2/output-0000/arrangements/Scalar/TwoPunctures_BBHSF/test/SF_twopuncturesID_test.par' line 166: Parameter 'LeanBSSNMoL::eta_beta_dynamic' not found
WARNING level 0 from host fv-az357-438.xjukslrwoije1kgjy1zwota3vf.cx.internal.cloudapp.net process 1
in thorn Cactus, file /home/runner/work/tests/tests/master/configs/sim/build/Cactus/main/ProcessParameterDatabase.c:201:
-> CCTKi_SetParameterSetMask: 1 major error in parameter file
--------------------------------------------------------------------------
MPI_ABORT was invoked on rank 0 in communicator MPI_COMM_WORLD
with errorcode 1.
```
which, if one scrolls to the right, refers to a parameter `LeanBSSNMoL::eta_beta_dynamic`which is not found.
“major” since it should be fixed before the next release and no know workaround \(to make the tests pass\) exists.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2738/caunda-proca-and-…
#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic"
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Hello all, not sure if this is already internally tracked by Canuda, but the commits that "remove parameter eta\_beta\_dynamic" seem to have made tests fail. See [https://einsteintoolkit.github.io/tests/build\_683.html](https://einsteinto… where it lists commit 12 and the failed tests. Unfortunately the ET test system had been offline for a bit \(due to GitHub removing python2 from the system\) and the change was not visible in the test results right away and so that report contains many \(unrelated\) changes. What I would guess are the relevant changes are:
> updated submodules
> Submodule repos/lean\_public 0faaf83..7457e18:
> > LeanBSSNMoL: remove parameter eta\_beta\_dynamic from test parameter files
> > NPScalars \[schedule.ccl\]: fix scheduling of CalcNPScalars
> > LeanBSSNMoL: remove unused parameters eta\_beta\_dynamic and moving\_eta\_transition
> > LeanBSSNMoL \[schedule.ccl\]: remove sync call in LeanBSSN\_adm2bssn
> > LeanBSSNMoL \[schedule.ccl\]: make sure that ApplyBCs at CCTK\_INITIAL is only called after Boundary\_SelectGroupForBC are set
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2738/caunda-proca-and-…
#2723: No boundary conditions registered for variables in group LEANBSSNMOL
Reporter: Vikram Manikantan
Status: open
Milestone: ET_2023_05
Version: ET_2022_11
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Vikram Manikantan):
status: open (was resolved)
Comment (by Vikram Manikantan):
From latest comment.
The issue is still present even with the suggested fixes, so I am reopening this ticket.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2723/no-boundary-condi…
#2723: No boundary conditions registered for variables in group LEANBSSNMOL
Reporter: Vikram Manikantan
Status: resolved
Milestone: ET_2023_05
Version: ET_2022_11
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Vikram Manikantan):
@{557058:65c5f18c-c3ad-4126-bb2b-be0e766b31ef} @{557058:088051f9-5b94-4b5e-bfbe-71137030b9c1} Thanks for your replies.
Even after using the updated master branch, the issue is still persistent. I even double checked that the changes in schedule.ccl have been made. Is this issue a concern?
I am reopening this ticket.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2723/no-boundary-condi…
#2737: define CCTK_DEVICE and CCTK_HOST in Cactus
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: enhancement
Priority: minor
Component: Cactus
Cactus supports CUDA programming in the option lists level via various `CUDA_FOO` variables but does not provide macros for `__device__` and `__host__` modifiers used by both CUDA and HIP accelerators.
It would be good if Cactus could provide those depending on which compiler is detected, Predefined defines to look for are \(copying AMReX\): `CUDA_ARCH || HIP_DEVICE_COMPILE || SYCL_DEVICE_ONLY` \(in its `include/AMReX_GpuQualifiers.H`\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2737/define-cctk_devic…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Vikram Manikantan):
Hi Leonardo,
In your suggested modification above, do you mean to replace the current lines that have ‘SetTmunu’ or just append this IF statement to the end of the file? See below for existing code in schedule.ccl.
```
schedule IllinoisGRMHD_conserv_to_prims in SetTmunu after (compute_B_and_Bstagger_from_A, TmunuBase_ZeroTmunu)
{
LANG: C
} "Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder."
schedule IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz in SetTmunu after IllinoisGRMHD_conserv_to_prims
{
# We must sync {P,rho_b,vx,vy,vz} here.
SYNC: grmhd_primitives_allbutBi
LANG: C
} "Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velocities pointed inward from outer boundary are set to zero."
```
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2736: consider using git+https together with a branch name or kuibit install
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: enhancement
Priority: trivial
Component: Other
Comment (by Gabriele Bozzola):
In addition, kuibit comes with an internal notion of version \(\`kuibit.\_\_version\_\_\`\), which is used for deprecated features or to check if some features are available. If I don’t change this, `kuibit@ET_2023_05`would still advertise itself as version 1.4.0, which might introduce some confusion.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2736/consider-using-gi…