Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns
by Samuel Cupp 13 Jun '23

13 Jun '23

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Also, what is the preferred method for alerting users to a deprecated feature? `CCTK_VWARN`?`CCTK_VINFO`? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2742/change-seed_magne…

1 0

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns
by Samuel Cupp 13 Jun '23

13 Jun '23

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} In regards to deprecation, correct me if I’m wrong: the best approach to merge the two thorns is to A\) Introduce the extra stuff to SMF to allow for BNS as well B\) Ensure the default behavior of Seed\_Magnetic\_Fields \(SMF\) is as before C\) Add deprecation warning for SMF\_BNS thorn D\) In the release after the one where this is added, remove the SMF\_BNS thorn entirely -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2742/change-seed_magne…

1 0

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns
by Samuel Cupp 13 Jun '23

13 Jun '23

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278} , I would like your input on how you’d like me to change the scheduling, and whether you prefer two thorns or one. It seems strange for Seed\_Magnetic\_Fields\_BNS to be in the diagnostics repo, especially when we can just have 1 thorn to provide both. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2742/change-seed_magne…

1 0

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic"
by Roland Haas 13 Jun '23

13 Jun '23

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic" Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Still fails _one_ \(1\) test: [https://einsteintoolkit.github.io/tests/build\_689.html](https://einsteinto… Note that the table lists 1 Failed Test and 4 Newly Passing Tests ie your commit fixed 4 tests. There was a bit of a delay since I had to do some emergency cleanup so that the test do not run out of quota on GitHub \(we have accumulated about ~20GB of test results in the repository and GitHub does not like this\). The tests all run right now, but the failing one \(teukolsky in NPSacalars\) shows significant \(ie higher than the set threshold\) differences from the recorded known-good values. See eg the diffs files linked \(the link labelled “diffs” in the table\) on the website for the build: [https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version\_689… I have \(obviously\) no clue if this due to data needing to be regenerated due to the committed code changes or if this is some sort of roundoff level sensitivity that would require a less stringent error threshold to pass on multiple machines due to different compiler settings. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2738/caunda-proca-and-…

1 0

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns
by Samuel Cupp 13 Jun '23

13 Jun '23

#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Right now, this thorn schedules based on the `ID_converter_ILGRMHD` function, preventing it from being used out-of-the-box by `GRHayLMHD`. I could change the scheduling to explicitly depend on this thorn, but a cleaner solution is to make their scheduling be based on HydroBase’s groups, providing a more consistent interface. As such, I propose that the seeding function be set to run `before HydroBase_Prim2ConInitial`. There’s a similar issue with Seed\_Magnetic\_Fields\_BNS in that it can only be guaranteed to work with `Meudon_Bin_NS`. Since both thorns should be changed to behave in a similar manner, I propose simply merging them into one. An example of this is in a [PR](https://bitbucket.org/zach_etienne/wvuthorns/pull-requests/14). However, I’m not sure of the best way to handle the deprecation/behavior changes. It might be simpler to just make a new thorn \(possibly in the GRHayL repo\) that provides the combined thorn while keeping the old ones in their current state. This PR also contains a bug fix for `ID_converter_GiRaFFE` and a very small optional feature for `IllinoisGRMHD` which I can make separately if we decide to make a new thorn instead of changing the existing one. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2742/change-seed_magne…

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Samuel Cupp 13 Jun '23

13 Jun '23

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Samuel Cupp 13 Jun '23

13 Jun '23

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no" Reporter: Gabriele Bozzola Status: open Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): I’m not sure what your schedule.ccl currently looks like, but the master branch of \`IllinoisGRMHD\` only has those two functions \(which I’ll refer to as con2prim\) in AddToTmunu, not SetTmunu. Did you also add it to SetTmunu? All Leo did was change the scheduling from something that looks like ``` schedule con2prim in AddToTmunu ``` to ``` if(stress_energy_at_RHS) { schedule con2prim in AddToTmunu } else { schedule con2prim in HydroBase_Con2Prim } ``` ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…

1 0

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic"
by Miguel Zilhão 12 Jun '23

12 Jun '23

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic" Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Miguel Zilhão): I see, sorry, I should have read properly the description that this is happening in the scalar and proca arrangements :-\) I've removed the parameter that was giving problems in the following commits: * [https://bitbucket.org/canuda/proca/commits/d24ddf835b0552410175fab2f6f84fe1… * [https://bitbucket.org/canuda/scalar/commits/44df0f7bb4afa01b406a5876acd107a… I hope this is now fixed. ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2738/caunda-proca-and-…

1 0

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic"
by Roland Haas 12 Jun '23

12 Jun '23

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic" Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Yes, this is still happening. You can take a look at the tests at [https://einsteintoolkit.github.io/tests/](https://einsteintoolkit.github.io… The LeanBSSN\_Ei\_mu0.4\_c0.05.log test \(you can click on the “log” link to access the output file\) fails with ``` Major error in parameter file '/home/runner/simulations/TestJob01_temp_1/output-0000/arrangements/Proca/NPScalars_Proca/test/LeanBSSN_Ei_mu0.4_c0.05.par' line 150: Parameter 'LeanBSSNMoL::eta_beta_dynamic' not found ``` which should also fail on your system Did you maybe forget to push all changes? I just tried and I get a test failure for the LeabBSSN Ei test as well after a fresh checkout on my workstation: ``` ./GetComponents --parallel --shallow https://bitbucket.org/einsteintoolkit/manifest/raw/master/einsteintoolkit.th ``` Please note that there are apparently multiple tests in Canuda named `LeanBSSN_Ei_mu0.4_c0.05.par` and the one that fails is `./repos/Proca/NPScalars_Proca/test/LeanBSSN_Ei_mu0.4_c0.05.par`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2738/caunda-proca-and-…

1 0

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic"
by Miguel Zilhão 12 Jun '23

12 Jun '23

#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic" Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Miguel Zilhão): This was indeed a problem, but it should have been fixed with commit [https://bitbucket.org/canuda/lean\_public/commits/7457e1822e3a880efd67e11f1… On my machine all tests are currently passing… Is this still a problem with the current master branch? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2738/caunda-proca-and-…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac