#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Samuel Cupp):
It’s been a while since I looked at it, but I think it should be `in HydroBase_PostStep after HydroBase_Con2Prim`. `update_Tmunu` is a parameter, not something in the scheduler. If you don’t want IllinoisGRMHD to ever set Tmunu, then you need to set that to `no` in the parfile. It defaults to `yes`. I didn’t get nans with `update_Tmunu=yes`, but I did with `update_Tmunu=no`.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Vikram Manikantan):
Also, I do not have `update_Tmunu` in my scheduler anywhere. What do you mean when you say you set this?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Vikram Manikantan):
The scheduling is already `in HydroBase_Con2Prim after IllinoisGRMHD_conserv_to_prims`. Do you mean to make it `in HydroBase_PostStep after HydroBase_Con2Prim after IllinoisGRMHD_conserv_to_prims` or just `in HydroBase_PostStep after HydroBase_Con2Prim`?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2738: Caunda/Proca and Canuda/Scalar test faiilures after commits that "remove parameter eta_beta_dynamic"
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Miguel Zilhão):
That one was was due to another commit, and indeed the data needed to be regenerated. I’ve done so here: [https://bitbucket.org/canuda/lean\_public/commits/e13352d877a5a5b6699a9ec66…
I hope this fixes it. The test now passes on my machine, but at the moment I have no other machine to try.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2738/caunda-proca-and-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Samuel Cupp):
To have more correct scheduling, change the `in HydroBase_Con2Prim` to `in HydroBase_PostStep after HydroBase_Con2Prim.`
This is because that con2prim group also runs in PostPostInitial where IllinoisGRMHD manually schedules functions. This should only put it in the places where AddToTmunu appears. I still get nans, but I don’t have time right now to track down where they come from. If you track down where they first appear, please let me know.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Samuel Cupp):
My previous comment was incorrect, as I forgot to also set `update_Tmunu`. I do get nans when I set that. I haven’t tried to debug this, but my guess is that moving this to a different bin leads to the A->B routine happening in a different place relative to con2prim, which causes this issue.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…