#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone: ET_2023_05
Version:
Type: enhancement
Priority: major
Component:
Comment (by Samuel Cupp):
@{5b32699bfa7c4336fcbd9647} why does the neutron star trajectory not start at the same point for both? That seems to be an error, is it not?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone: ET_2023_05
Version:
Type: enhancement
Priority: major
Component:
Comment (by Alireza R.):
”Attached, please find the orbit comparisons between BAM and ETK codes. As far as the loading of the initial data goes, they match, i.e., the metric and hydro fields populated on the correct region of the grid and, as a result, orbiting in the expected direction. There is an offset for NS trajectories, and I believe the difference is related to the grid structure that we set in the parameter file.
The deviation of BH trajectories is something that we are investigating now and requires more time to find out the best configuration for this new BHNS system. Please let me know what you think and if this is sufficient to include Elliptica in this release. Thanks!”



--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone: ET_2023_05
Version:
Type: enhancement
Priority: major
Component:
Changes (by Roland Haas):
milestone: ET_2023_05 (was )
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
I changed manifest/master’s `einsteintoolkit.th` to refer to the default branch for `EllipticaID` \(and verified that the BHNS reader in there agrees with the one in `Elliptica_BHNS`\) and pushed the change \(mostly so that those are used for testing on clusters\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
To update the thornlist in manifest? Sure. I just gave you commit rights so you can also directly commit to manifest \(just be a bit careful to not change more than the thing you would like to change, eg running a `git diff origin/master..master` before you push\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Alireza R.):
Should I ask for a pull request now?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Alireza R.):
Thanks, Roland, for the comments. Regarding the Elliptica\_ID\_Reader repo., as you mentioned, there is a dedicated Cactus branch; hence, all future updates and features for Cactus will remain in this branch. For the EllipticaID repo. , following your comments, we merged everything into the main branch. Thanks!
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2526: McLachlan has incorrect READ declarations for presync.
Reporter: Peter Diener
Status: new
Milestone: ET_2023_05
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
responsible: [] (was [])
milestone: ET_2023_05 (was ET_2021_05)
assignee: Ian Hinder (was Roland Haas)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2526/mclachlan-has-inc…
#2526: McLachlan has incorrect READ declarations for presync.
Reporter: Peter Diener
Status: new
Milestone: ET_2021_05
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Please review.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2526/mclachlan-has-inc…