Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Samuel Cupp 05 Apr '23

05 Apr '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Samuel Cupp): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} Do you mind if I also move the canuda-lean down with the other canuda repos? Its a bit weird that there are several repos between them despite the header ``` # Canuda thorns #=============== ``` since the intervening repos are clearly not canuda. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Samuel Cupp 05 Apr '23

05 Apr '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Samuel Cupp): I can change the manifest to point to master. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Cheng-Hsin Cheng 05 Apr '23

05 Apr '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Cheng-Hsin Cheng): Hi all, after discussing with the other authors and maintainers of Canuda/Scalar, we decided to merge TwoPunctures\_BBHSF from the branch `proposal_ET_2023_05` into `master`. So any updates or bug fixes for the new thorn will happen on `master`, and `proposal_ET_2023_05` would not be maintained. @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} could we update the manifest thornlist to use the master branch for Scalar? Should we make another pull request for the change, or can the release team just make the changes? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2692: Inclusion of FUKA importer thorns
by Roland Haas 05 Apr '23

05 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): The only docs that exist are: [https://docs.einsteintoolkit.org/et-docs/Release\_Process#create\_branches]… The script shown there should work for the Kadath codes in this ticket due to $3$. They are basically the same as Kranc and its Examples repo $also a submodule with fixed git hash$. You _will_ have to $at this point$ manually handle `proposal_ET_2023_05` in canuda/scalar since that is not the “default” branch and script fragment on the wiki assumes that one branches of release branches from the current head of the default branch. This most likely can $and should$ be changed so that one can run the script fragment in the repository structure created by GetComponents on the master thornlist from the `manifest` repo and make it assume that the branching happens off the currently checked out branch $which for canuda/scalar is currently `proposal_ET_2023_05`$. This $probably$ just means removing the: ``` default_branch=$(git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remotes/origin/@@') ``` and ``` git checkout $default_branch ``` lines. It will also affect how one learns which changes to announce $which also looks at the default branch$, but that process requires some human interaction anyway. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2692: Inclusion of FUKA importer thorns
by Samuel Cupp 05 Apr '23

05 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Sorry, but I didn’t really follow the specifics of point 3, as I haven’t dealt with anything that doesn’t just have a branch called “ET\_release\_date”. I am fine with having commit access so I can make the branches. If there’s something special that needs to be done for some repos, is there a guide or something on the wiki about these cases? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2690: Include new IllinoisGRMHD with tabulated and hybrid EOS support
by Roland Haas 05 Apr '23

05 Apr '23

#2690: Include new IllinoisGRMHD with tabulated and hybrid EOS support Reporter: Leonardo Werneck Status: new Milestone: ET_2023_05 Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): This is pretty much a duplicate of #2300, ins’t it? Keep in mind then, that my comments about changing / removing parameters apply: [https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecew… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2690/include-new-illin…

1 0

#2300: Update: Add Piecewise Polytrope EoS Support to IllinoisGRMHD, Improved TOV Solver?
by Roland Haas 05 Apr '23

05 Apr '23

#2300: Update: Add Piecewise Polytrope EoS Support to IllinoisGRMHD, Improved TOV Solver? Reporter: Zach Etienne Status: open Milestone: Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): Is this being superseded by #2690 ? If so it should be closed as a duplicate. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecew…

1 0

#2692: Inclusion of FUKA importer thorns
by Roland Haas 05 Apr '23

05 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): @{557058:088051f9-5b94-4b5e-bfbe-71137030b9c1} @{5bae587b96242d2e2b6110a4} ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2692: Inclusion of FUKA importer thorns
by tootle 05 Apr '23

05 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by tootle): I’ve resolved $1$ and $2$. For $3$, thanks for the information related to using submodules in git. Regarding the actions just prior to the release, I have no issue adding someone to the thorn repos to make their $our$ lives easier if it allows for a level of automation. They can reach out to me and let me know $here or e-mail$ Re: what they prefer and I’ll make it happen. Thanks a lot Roland! -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#1775: Add Boost to ET
by tootle 05 Apr '23

05 Apr '23

#1775: Add Boost to ET Reporter: Erik Schnetter Status: new Milestone: Version: development version Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by tootle): For my 2cents, I think it is an excellent idea to add a thorn that can detect boost libraries, but I think having to include the ability to build the whole library is too much bloat not to mention compile time. The number of dependencies that boost has in order to build the full suite is incredibly large - run spack concretize for a full boost spec and you’ll see what I mean. Even on our cluster, boost alone can take 30\+ minutes to compile the full suite including dependencies. I understand this goes against the ETK paradigm of everything that is needed is included, which should definitely be the case for fundamental components such as Carpet $glad to hear CarpetX will remove the boost dependency$, but I think it would be more useful to fail gracefully and list the Thorns that depend on boost rather than defaulting to building the entire suite. Also, for modern clusters boost is usually available by default, but the environments may not be updated correctly making automated searches like those in Radice’s boost not robust. Cmake has incredibly good features for finding boost as well as individual components, but this still depends on the environment correctly setting \`BOOST\_ROOT\`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1775/add-boost-to-et

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac