#2549: inlcude FLRWSolver in ET
Reporter: Roland Haas
Status: new
Milestone: ET_2022_05
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Chi Tian):
Hi all, I have reviewed the documents and majority of the the codes. At least at physics level, everything looks fine to me. Only some tiny issues regarding the way FLRWSolver dealing with the extrinsic curvature:
1. It seems there is a typo in Eq. \(10\) in the document, where minus sign is missing \(at least for the case where the author mentions “Setting f =1/3 and n=2 in the above yields ∂tα=∂ta for EdS“\).
2. The name of the variable `kvalue` in several `flrw_*.f90` files seems a little confusing. From its name, it seems this variable represents the extrinsic curvature K. However, its true value seems to be `3 * kvalue` if my understanding was correct.
3. By following the gauge condition `\dot{\alpha} = f * K`, effectively it is setting the coordinate time to something closed to the conformal time `\eta`, and the value of `\alpha` will grow roughly following the growth of the scale factor `a`. Could this possibly introduce numerical instabilities to `GRhydro` when starting from a very high redshift, and universe keeps expanding for quit long? Since I would guess most of astrophysical GR simulations may choose gauge conditions that make `\alpha` close to 1.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…
#2636: CoordinateSymmetry has a parameter `rotating_90` that is never used
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component:
As in title. Grepping “rotating” in the llama repository doesn’t produce any result.
Overall, it is unclear \(to me at least\) what symmetries are supported with multipatch grids.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2636/coordinatesymmetr…
#2630: WaveMoL example computes energy from unsynchronized grid variables
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component:
Comment (by Roland Haas):
Unless objected I apply this after 2022-09-08
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2630/wavemol-example-c…
#2549: inlcude FLRWSolver in ET
Reporter: Roland Haas
Status: new
Milestone: ET_2022_05
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Zach Etienne):
Issue 12: `init_tools.F90` contains routines from another library “MESCALINE” but does not contain a link to the library or author attribution. Possible software license violation.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…
#2549: inlcude FLRWSolver in ET
Reporter: Roland Haas
Status: new
Milestone: ET_2022_05
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Zach Etienne):
Comment 4: I’m rather confused as to why `random.F90` exists. It seems to be a custom RNG. Why not use something off the shelf?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…
#2549: inlcude FLRWSolver in ET
Reporter: Roland Haas
Status: new
Milestone: ET_2022_05
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Zach Etienne):
Issue 11: `random.F90` contains a code snippet “found on stackexchange”, but does not contain a link to the SE article. Complete attribution needed.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…
#2549: inlcude FLRWSolver in ET
Reporter: Roland Haas
Status: new
Milestone: ET_2022_05
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Zach Etienne):
Issue 10: A more detailed description of what `par/FLRW_powerspectrum_restart.par` does in that file would be appreciated. It’s rather unusual and probably violates ET standards to have a separate parameter file just for restarting from checkpoints.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…
#2549: inlcude FLRWSolver in ET
Reporter: Roland Haas
Status: new
Milestone: ET_2022_05
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Zach Etienne):
Issue 9: Running `par/FLRW_powerspectrum.par` results in a _FORTRAN runtime error_, as `/path/to/flrwsolver/powerspectra/FLRW_matterpower_synchronous_z1000.dat` does not exist. It would be better to check for the file’s existence in the Einstein Toolkit CCTK\_\*ERROR infrastructure, and would be a great opportunity to tell the user how to generate this file.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…