Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 8: There are two `FLRW_singlemode.par` files: one in `par/` and one in `test/`. These seem to be two very different files, so adjusting the filename to be more descriptive would help new users browsing these example parameter files. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Comment 3: Instead of storing simfactory configs for machines within a thorn’s repo, consider contributing them to `SimFactory` . -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 7: There are two, slightly different, copies of the `Plot_ET_data.ipynb` tutorial in the repo: one in `doc/tutorial` and one in `tools/`. This could make the thorn more difficult to maintain moving forward. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Comment 2: `documentation.tex` only refers to one Python script in `tools`, despite there being 5 scripts in that directory _and_ a Jupyter notebook. It would be so nice to reference these in the documentation, as they are likely to be very useful to new users. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 6: I couldn’t find reference to the example power spectrum \(see `powerspectrum/`\) in the documentation. This would be a useful addition. Also I liked that when I went into `powerspectrum/` I was greeted with a `README` file explaining the basics of what this was. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Comment 1: I _really_ like `README.Compilation` as it contains some useful “gotchas” that folks often run into when trying to compile the Toolkit more generally. For example: ``` --> Generally, if you have a nontrivial error with a particular thorn, first try removing that thorn from the thornlist and re-compile. The code will complain if other thorns on your thornlist depend on the thorn you have just removed. You can also remove some of these if they are not important. If it turns out a thorn you really need has a dependency on that thorn, ONLY THEN spend the time debugging. ``` I feel like the contents of this file would make an excellent contribution to a wiki page. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 5: I’m a bit confused as to why `check_metric()` is `something that we do at the end of each initial data routine`. All it does is: ``` if (CCTK_EQUALS (metric_type, "physical")) then ! do nothing else call CCTK_WARN (0, "Unknown value of ADMBase::metric_type -- FLRW only set-up for metric_type = physical") endif ``` This parameter cannot change while `FLRWSolver` is being run, or at all after the parfile is read in, so it only needs to be checked once. In fact I think there’s a scheduling bin for it: `ParamCheck`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 4: `doc/cactus.sty` should be removed. I understand that this is a convenient location for the file when running e.g., `pdflatex documentation.tex` from within the `doc` directory, but this file already exists in the Toolkit in a standard place that is looked at when e.g., `make AllDoc` is run. It's best that this remains the situation in case we'd like to update the style file. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 3: The `test/` directory contains a parameter file and sample output data, which has no problem running and seems to use little resources. Great work! What’s missing is the required `test.ccl` file that sets acceptable tolerances when running this thorn through our unit testing infrastructure. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 2: Compiler warning needs to be resolved \(looks scary\): `src/powerspec_ics.F90:16: Warning: While tracing include dependencies: Include file "fftw3.f03" not found` -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac