#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
Not sure if that test ever actually tested for NaNs. At least \`git log -G \[Nn\]\[Aa\]\[Nn\]' does not find anything. There is a test in NaNChecker that had to use some extra code to produce NaNs for it to find in git hash [837d426](https://bitbucket.org/cactuscode/cactusutils/commits/837d4260c2608… "NaNChecker: use internally generated NaNs in test case" of [cactusutils](https://bitbucket.org/cactuscode/cactusutils) .
Should be enough to have a regex looking for `nan` and `[+-]inf` where the current regex expects the numeric part I suspect and \(possibly\) some extra code in the C\+\+ code to convert those to NaN and inf, if that is not automatically done by the routine used to convert real number strings to double values.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
I don’t see a test failure. Maybe something changed?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#1437: Missing option for deterministic noise in CactusNumerical/Noise
Reporter: Frank Löffler
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Steven R. Brandt):
Possible hackathon task
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1437/missing-option-fo…
#2553: Cactus' link command uses CPPFLAGS and CXXFLAGS
Reporter: Roland Haas
Status: open
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
I think we should fix this issue now, while the current release is still young. That will give us time to notice any build failures likely to occur.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2553/cactus-link-comma…
#1532: The ET should handle "optional" thorns (OpenCL ect) in a better way.
Reporter: Roland Haas
Status: resolved
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: Cactus
Changes (by Roland Haas):
status: resolved (was open)
Currently, some thorns within the ET only work on some machines (for good reasons), and are thus disabled by default in the thornlist. This has several problems (they are not checked out by default, nor then synced to machines where they are supported and might be needed). We need to improve this.
We could find a way to tag these as "optional" and then have a corresponding tag per machine that can enable them, if they are present. This way (at least most of them) could always be checked out, but Cactus would skip their compilation if they are not present, or not supported on that machine (indicated by something "missing" in the option list probably).
**Keyword:**
Comment (by Roland Haas):
This has been fixed long ago in the way Frank describes and using simfactory's enable-thorns and disable-thorns options along with `#DISABLED ` markers in the thornlist
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1532/the-et-should-han…
#2499: New machine thornyflat at WVU
Reporter: Erik Schnetter
Status: open
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: SimFactory
Comment (by Maria):
Roland,
Yes, of course! I'll have this sorted out.
I also proposed to test Bridges II.
Maria
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2499/new-machine-thorn…
#2529: Flang error in Cactus/src/util/PointerTo.F90
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: Cactus
Comment (by Roland Haas):
Looking into this might be a hard hackathon task \(since it involves autoconf in some capacity\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2529/flang-error-in-ca…
#2499: New machine thornyflat at WVU
Reporter: Erik Schnetter
Status: open
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: SimFactory
Comment (by Roland Haas):
@{557058:bd4e7bbf-5b51-4a78-8af3-139afa0dcfe5} , can you verify that the files in the pull request work for you and will you volunteer to keep them up to date in the future and \(ideally\) test them for each ET release \(or designate someone who will do so\)?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2499/new-machine-thorn…