Trac

trac@lists.einsteintoolkit.org

8708 discussions

[Einstein Toolkit] #2051: CST stage always regenerates all files
by Einstein Toolkit 27 Jun '17

27 Jun '17

#2051: CST stage always regenerates all files ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Cactus | Version: development version Keywords: | ----------------------+----------------------------------------------------- I notice that since recently, the Cactus CST stage always regenerates all files, which means that any change to a ccl file or the thorn list will recompile all source files, which is very slow. I find that this patch resolves the problem: {{{ $ git diff CSTUtils.pl diff --git a/lib/sbin/CSTUtils.pl b/lib/sbin/CSTUtils.pl index 532f6a77..209b9352 100644 --- a/lib/sbin/CSTUtils.pl +++ b/lib/sbin/CSTUtils.pl @@ -182,8 +182,8 @@ sub WriteFile if (-e $filename) { # only read the file if it its size equals the length of the rdata string - my @fileinfo = stat ($filename); - if ($fileinfo[7] == length ($$rdata)) + my $filesize = -s $filename; + if ($filesize == length ($$rdata)) { open(IN, "< $filename"); $data_in = join ('', <IN>); }}} Apparently, something fishy is happening when calling {{{stat}}}. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/2051> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 7

[Einstein Toolkit] #2039: Meudon_Bin_NS update
by Einstein Toolkit 20 Jun '17

20 Jun '17

#2039: Meudon_Bin_NS update -----------------------------------+---------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- The attached patch generalizes the Meudon_Bin_NS thorn: - to be able to use any value for 'gamma' (EoS) other than 2 - to be able to use an EoS provided by EOSOmni. In particular, this enables piecewise polytropes of any kind, as long as the initial data was generated using the same "table" ... along with a few minor changes: - check that the input file name exists - add a few more parameter descriptions - allow setting the derivatives of the gauge to zero while still taking the gauge from Lorene While a patch is attached, the new version could probably be tested the easiest from https://bitbucket.org/GravityPR/prthorns/src/master/Meudon_Bin_NS -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/2039> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 16

[Einstein Toolkit] #583: PITTNullCode lacks test case outputs
by Einstein Toolkit 13 Jun '17

13 Jun '17

#583: PITTNullCode lacks test case outputs -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- The PITTNullCode arrangement has several test parameter files without associated output. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/583> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 1

[Einstein Toolkit] #1986: this compared to NULL in CarpetLib
by Einstein Toolkit 13 Jun '17

13 Jun '17

#1986: this compared to NULL in CarpetLib --------------------+------------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | --------------------+------------------------------------------------------- I get {{{ /home/rhaas/Cactus/arrangements/Carpet/CarpetLib/src/gdata.cc: In member function ‘void gdata::copy_from(comm_state&, const gdata*, const ibbox&, const ibbox&, const islab*, int, int)’: /home/rhaas/Cactus/arrangements/Carpet/CarpetLib/src/gdata.cc:185:53: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare] int const order_space = (this ? cent : src->cent) == vertex_centered ? 1 : 0; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ }}} which leads me to suspect that the compiler is allowed to assume this != NULL and will optimize out one half of the condition. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1986> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 8

[Einstein Toolkit] #1821: Carpet may call object methods with this == NULL
by Einstein Toolkit 13 Jun '17

13 Jun '17

#1821: Carpet may call object methods with this == NULL ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: new Priority: optional | Milestone: Component: Carpet | Version: development version Keywords: | ----------------------+----------------------------------------------------- see pull request https://bitbucket.org/eschnett/carpet/pull-requests/7 /carpet-avoid-using-null-pointer-for-member/diff -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1821> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 13

[Einstein Toolkit] #2047: support mesh refined grid scalars and grid arrays
by Einstein Toolkit 12 Jun '17

12 Jun '17

#2047: support mesh refined grid scalars and grid arrays -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | -------------------------+-------------------------------------------------- Every once in a while it would be useful if one had access to scalar/array variables for which there was one copy per refinement level and that may or may not restrict from the fine into the coarse levels. Examples are * evolving particles along with the fields (restriction would happen) if there is actual back-and-forth interaction between particles and fields (ie not just tracers) * keeping track of a reduced quantity on a per-reflevel basis (eg. number of times RHS was evaluated for this level), not restriction in this case -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/2047> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 1

[Einstein Toolkit] #2048: WaveMoL test gaussian.par uses uninitialized memory
by Einstein Toolkit 11 Jun '17

11 Jun '17

#2048: WaveMoL test gaussian.par uses uninitialized memory --------------------+------------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Keywords: | --------------------+------------------------------------------------------- WaveMoL's IDWaveMoL thorn only sets up ID on the current timelevel. However the gaussian.par test using radiative boundary conditions which require valid values on the previous timelevel. With PUGH it seems that these values are usually zero (either because PUGH clears memory or because malloc() does). With Carpet however, poisoning is the default and one finds that NaNs show up from the boundary, one per timestep. This can be avoided by setting mol::initial_data_is_crap = yes (or the equivalent Carpet parameter if one uses Carpet) in the parfile. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/2048> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 0

[Einstein Toolkit] #2044: Piraha: Make it possible to enable/disable either the old or new parser
by Einstein Toolkit 02 Jun '17

02 Jun '17

#2044: Piraha: Make it possible to enable/disable either the old or new parser -------------------------+-------------------------------------------------- Reporter: sbrandt | Owner: Type: enhancement | Status: new Priority: unset | Milestone: Component: Other | Version: development version Keywords: | -------------------------+-------------------------------------------------- This feature was requested in the ET phone call to prepare for the release. https://bitbucket.org/cactuscode/cactus/pull-requests/39/normalize-error- messages/diff -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/2044> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 4

[Einstein Toolkit] #1674: Switch to OpenBLAS
by Einstein Toolkit 02 Jun '17

02 Jun '17

#1674: Switch to OpenBLAS -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: Other | Version: development version Keywords: | -------------------------+-------------------------------------------------- OpenBLAS is a BLAS and LAPACK library that is significantly more efficient that the standard ("reference") BLAS. I suggest we switch the ET thorn list to ExternalLibraries/OpenBLAS instead of ExternalLibraries/BLAS and ExternalLibraris/LAPACK. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1674> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 22

[Einstein Toolkit] #2038: Two src file versions in GRHydro: GRHydro_Con2PrimM_pt_EOSOmni.c.hopefullyfixed.c
by Einstein Toolkit 31 May '17

31 May '17

#2038: Two src file versions in GRHydro: GRHydro_Con2PrimM_pt_EOSOmni.c.hopefullyfixed.c -----------------------------------+---------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: new Priority: minor | Milestone: ET_2017_05 Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- I did not look deeply into this file, but it seems to be a variant of GRHydro_Con2PrimM_pt_EOSOmni.c that is not actually used when building GRHydro. We should not have artifacts like that in our repositories. If there is an issue, please report it as ticket. Given that the history of that file goes back to 2012, has seen rarely any change besides source code formatting and the like, and the last change is from 2013, I suggest to remove the file. https://bitbucket.org/einsteintoolkit/einsteinevolve/src/82fdf7073e088f322f… =file-view-default -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/2038> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac