#1043: RotatingSymmetry180::poison_boundaries should not check for NaNs -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: McLachlan | -----------------------------------+---------------------------------------- currently poison_boundaries causes RotatingSymmetry180 checks for both the poison value and for nonfinite values in the boundary. It should probably not check for NaN in case there are grid functions that do actually contain nan values near the boundaries (right not I have a run where this is true for ML_BSSN::H where I don't care about the NaNs). RotatingSymmetry's output completely clutters stdout since it list every single nan point it find.
If one wants to check for NaN values in the constraints one can always use NaNChecker so no functionality is lost.
Also RotatingSymmetry might well see NaN values when combined with say ReflectionSymmetry if the NaNs would be overwritten by say a z-reflection symmetry afterwards (I am not sure what the order in which symmetries are applied is).
#1043: RotatingSymmetry180::poison_boundaries should not check for NaNs ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: McLachlan ------------------------------------+---------------------------------------
Comment (by eschnett):
I attach patches that introduce new parameters "check_boundaries". When boundaries are poisoned, they are not automatically checked any more; this now requires setting this parameter as well.
#1043: RotatingSymmetry180::poison_boundaries should not check for NaNs ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: McLachlan ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#1043: RotatingSymmetry180::poison_boundaries should not check for NaNs ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: McLachlan ------------------------------------+---------------------------------------
Comment (by rhaas):
Patches look fine. Thank you Erik. Please apply.
#1043: RotatingSymmetry180::poison_boundaries should not check for NaNs ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: McLachlan ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org