#1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: unset | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

As far as I can tell this introduces (among other unrelated changes) a set of macros such that eg. {{{CCTK_VINFO("a %d", 42)}}} gets turned into {{{CCTK_VInfo(CCTK_THORNSTRING, "a %d", 42)}}} ie. one saves on the CCTK_THORNSTRING. The commit thus makes the {{{CCTK_UPPERCASE}}} macros more orthogonal to the corresponding {{{CCTK_LowerCase}}} functions since the difference between the two is now only that one set includes {{{CCTK_THORNSTRING}}}, {{{__LINE__}}}, {{{__FILE__}}} and the other one does not.

The patch is lacking documenation updates for the new macros and should not be applied without.

Comments:

* please provide documentation for the macros in CCTK_Reference.tex * there are extra changes that reformat lines that are not otherwise touched by the commit, I would leave those out if possible

Fine with me as long as the first point is taken care of (the second one is not crucial, but documentation is).

#1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: assigned Priority: unset | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):

* owner: => eschnett * status: new => assigned

Comment:

Related: #2005 is a report of code having been committed that depends on the proposed code in the current ticket which unfortunately breaks the build.

#1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: review Priority: unset | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by knarf):

Some points: - I don't link other changes in the same diff. It's ok for now, but please don't mix changes even if it just changes upper case / lower case of something unrelated - If I read the changes to the documentation correctly, places with, e.g., CCTK_VInfo are replaced by CCTK_VINFO. Isn't CCTK_VInfo still there, usable, and should stay mentioned, like in "Note that the routines \texttt{CCTK_VError()} and \texttt{CCTK_VWarn()} can only be called from C" - Seeing the diff of the pdf in github mixed with the other changes is annoying. I know this decision was made to keep the diffs to the pdfs small, but it is really annoying here.

#1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: review Priority: unset | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

(this was stuck in queue and apparently I forgot to hit "submit", sorry).

Please apply.

The commit makes the code build again. Some issues in the documentation remain:

* it replicates the information in the documentation section for CCTK_VWARN in CCTK_VWarn. One should be shortened to refer (with a link) to the other * the code change mixes new features in one section of the file with code reformatting in another. This makes it hard to review.

#1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: closed Priority: unset | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

These change have been applied via commit d05d608484f3b6e74a53f42693efab48343f54e7.