Present: Frank, Roland, Jonah, Peter, Steve, Erik, Matt, Ian, Yosef
Tickets up for application with no discussion happening: Decision to make it a policy to apply tickets that are up for review for a long time, for which no comments are made. This decision is then up to the person proposing the change in the commit.
ML rewrite branch: * Ian commented on the proposed changes * further discussion will continue to happen on Trac
Yours, Roland
On 26 Jan 2015, at 17:11, Roland Haas roland.haas@physics.gatech.edu wrote:
Tickets up for application with no discussion happening: Decision to make it a policy to apply tickets that are up for review for a long time, for which no comments are made. This decision is then up to the person proposing the change in the commit.
This seems a bit dangerous. Should it instead be up to the maintainers?
Hello all,
This seems a bit dangerous. Should it instead be up to the maintainers?
Usually the ones who fail to comment are the maintainers... The only ones that can commit are those whom we have given permission. We cannot stop them anyway and can always revert commits. I think the danger of having things committed may actually improve the review process a bit. Nothing motivates like ... :-)
Yours, Roland
users@lists.einsteintoolkit.org
-
Ian Hinder -
Roland Haas