Present: Peter, Roland, Frank, Matt, Steve, Ian, Erik
upcoming release: * release branches to be created today * Peter to commit fix to gaussian test data for ticket 1604 * Erik to regenerate all Kranc generated source code * list of release preparers for announcement: Peter, Roland, Ian, Frank, Bruno, Erik
git transition: * Frank and Ian to get into contact next week to test svn to git transition scripts * will try using bitbucket
Ongoing issues: Gallery: * small examples of non-trivial code * BBH (qc0): Ian * BH: Peter: working version on Peter's laptop * NSNS to BH: currently fails * TOV collapse: Roland was volunteered, but suspects this will fail
Yours, Roland
Sent from a mobile device
On May 12, 2014, at 12:05, Roland Haas roland.haas@physics.gatech.edu wrote:
Present: Peter, Roland, Frank, Matt, Steve, Ian, Erik
upcoming release:
- release branches to be created today
- Peter to commit fix to gaussian test data for ticket 1604
- Erik to regenerate all Kranc generated source code
Done.
-Erik
- list of release preparers for announcement: Peter, Roland, Ian, Frank,
Bruno, Erik
git transition:
- Frank and Ian to get into contact next week to test svn to git
transition scripts
- will try using bitbucket
Ongoing issues: Gallery:
- small examples of non-trivial code
- BBH (qc0): Ian
- BH: Peter: working version on Peter's laptop
- NSNS to BH: currently fails
- TOV collapse: Roland was volunteered, but suspects this will fail
Yours, Roland
Users mailing list Users@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/users
On Mon, May 12, 2014 at 09:05:55AM -0700, Roland Haas wrote:
- release branches to be created today
This is now done. The main development branches (trunk/master) are now open again. The new still-to-be-released thornlist is
https://svn.einsteintoolkit.org/manifest/branches/ET_2014_05/einsteintoolkit...
Frank Loeffler
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hello Frank, all,
This is now done. The main development branches (trunk/master) are now open again. The new still-to-be-released thornlist is
https://svn.einsteintoolkit.org/manifest/branches/ET_2014_05/einsteintoolkit...
Thank
you.
Would it still be possible to include (commented out) the IllinoisGRMHD code? This was in the minutes http://lists.einsteintoolkit.org/pipermail/users/2014-April/003548.html but apparently never actually done in the thorn list. I just tested a modified thornlist (see attached patch) and it compiles and links (and Zach tells me it also passes tests when compared to the older Illinois GRMHD code).
We also have some thorns in there that are to be archived and a handful of new thorns, see
http://lists.einsteintoolkit.org/pipermail/users/2013-December/003343.html
During the phone call we reached agreement to include:
* PAPI: want documentation, include * MemSpeed: want documentation, test case, include * dylib: include if compiles, WARN loudly if it cannot run at runtime * F5: want documentation, include * WaveToyCUDA: keep commented out, assuming testsuites and docs * Boost: objections to size of repo. ran out of time to reach conclusion
During the phone call we reached agreement to remove:
* uncontroversial: move ADMConstraints into EinsteinArchive and replace with ML_ADMConstraint which provides the same functionality. Reason: ADMConstraints uses old Tmunu interface (optionally) which is deprecated and will be removed. ADMConstraints also uses ADMMacros (is 4th order only etc) which are hard to maintain (we also found a bug in 2010: r107 "Undefine the guts instead of the declare") * uncontroversial: remove old Tmunu interface. Reason: eat up ~30% of total CPU time since it contains a CCTK_IsThornActive in the innermost loop * uncontroversial: retire ADMCoupling since it is only used for the deprecated Tmunu interface, FRIEND mechanism in Cactus is also no longer advertised as good usage. Requires fixes in Exact. * DistortedBHIVP, IDAxiBrillBH, IDAxiOddBrillBH, RoatingDBHIVP: mark as archived using comment. Remove from manifest (comment out) if tests fail. There are objections to moving the repository.
Retiring ADMCoupling at this stage may not be possible unless we already have the fixes for Exact in.
Yours, Roland
- -- My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://keys.gnupg.net.
On Tue, May 13, 2014 at 10:16:52AM -0700, Roland Haas wrote:
During the phone call we reached agreement to include:
- PAPI: want documentation, include
- MemSpeed: want documentation, test case, include
- dylib: include if compiles, WARN loudly if it cannot run at runtime
- F5: want documentation, include
- WaveToyCUDA: keep commented out, assuming testsuites and docs
- Boost: objections to size of repo. ran out of time to reach conclusion
I don't think it would be wise to include them now in the upcoming release. Too many things would need to be re-tested and could go wrong. However, please feel free to add them now to the development version so that we don't face that problem again in about 5 months.
During the phone call we reached agreement to remove:
- uncontroversial: move ADMConstraints into EinsteinArchive and replace
with ML_ADMConstraint which provides the same functionality. Reason: ADMConstraints uses old Tmunu interface (optionally) which is deprecated and will be removed. ADMConstraints also uses ADMMacros (is 4th order only etc) which are hard to maintain (we also found a bug in 2010: r107 "Undefine the guts instead of the declare")
This is marked as deprecated, but still included. It should stay that way, and should be removed in the current development version now.
- uncontroversial: remove old Tmunu interface. Reason: eat up ~30% of
total CPU time since it contains a CCTK_IsThornActive in the innermost loop
- uncontroversial: retire ADMCoupling since it is only used for the
deprecated Tmunu interface, FRIEND mechanism in Cactus is also no longer advertised as good usage. Requires fixes in Exact.
Same applies here.
- DistortedBHIVP, IDAxiBrillBH, IDAxiOddBrillBH, RoatingDBHIVP: mark as
archived using comment. Remove from manifest (comment out) if tests fail. There are objections to moving the repository.
I marked them now in the release branch. To be gone by the next release (meaning now in the development version).
This (including a lot of the stuff we agreed on to remove) is not ideal, but it didn't pose problems while testing, but could if we now remove it from the release. Let's phase them out the gentle way. I don't see harm done by doing so.
Frank
On Tue, May 13, 2014 at 10:16:52AM -0700, Roland Haas wrote:
Would it still be possible to include (commented out) the IllinoisGRMHD code? This was in the minutes http://lists.einsteintoolkit.org/pipermail/users/2014-April/003548.html but apparently never actually done in the thorn list. I just tested a modified thornlist (see attached patch) and it compiles and links (and Zach tells me it also passes tests when compared to the older Illinois GRMHD code).
I don't see a reason to not include it, commented out and mentioning that this is experimental - as in mentioned minutes.
Frank
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hello Frank, all,
I don't see a reason to not include it, commented out and mentioning that this is experimental - as in mentioned minutes.
Meaning I may apply the patch to the release branch?
Yours, Roland
- -- My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://keys.gnupg.net.
users@lists.einsteintoolkit.org
-
Erik Schnetter -
Frank Loeffler -
Roland Haas -
Roland Haas