Dear all,
in order to use the CactusNumerical/Noise thorn to perform a stress test on the hydro equations "id_noise" has to be properly scheduled with respect to HydroBase_Initial and HydroBase_Prim2ConInitial. As it is now numerical perturbation on the hydro variables could be discarded / overwritten.
The attached (trivial) patch fixes the above mentioned issue and includes some small aesthetic fixes. Could you please consider applying it to the development branch of the Einstein Toolkit?
Thanks, David
PS: note that the hydro thorn has to schedule Prim2Con in HydroBase_Prim2ConInitial otherwise the perturbation are simply ignored/overwritten.
On Tue, Jul 6, 2010 at 3:29 AM, David Radice david.radice@aei.mpg.dewrote:
Dear all,
in order to use the CactusNumerical/Noise thorn to perform a stress test on the hydro equations "id_noise" has to be properly scheduled with respect to HydroBase_Initial and HydroBase_Prim2ConInitial. As it is now numerical perturbation on the hydro variables could be discarded / overwritten.
The attached (trivial) patch fixes the above mentioned issue and includes some small aesthetic fixes. Could you please consider applying it to the development branch of the Einstein Toolkit?
David
Thanks for your patch; I have applied it.
PS: note that the hydro thorn has to schedule Prim2Con in
HydroBase_Prim2ConInitial otherwise the perturbation are simply ignored/overwritten.
I don't know about this. Frank, can you confirm this? Is there a problem in GRHydro?
-erik
On Fri, Jul 09, 2010 at 05:26:25PM -0500, Erik Schnetter wrote:
I don't know about this. Frank, can you confirm this? Is there a problem in GRHydro?
Prim2Con overwrites the converved variables which are used in the evolution to overwrite the primitive again. If now noise is added to the primitive variables after Prim2Con, this noise is not used in the evolution and will be overwritten, that is right. This is however not a problem in GRHydro, just a problem with the schedule of Noise - and this is what the patch took care of (in addition to the change in the error message which is also ok).
Frank
users@lists.einsteintoolkit.org
-
David Radice -
Erik Schnetter -
Frank Löffler