I think the option should instead be to disable the old parser. The new parser already helped us find bugs in ccl files, and the new parser is the future. There is no known instance where the new parser silently have wrong results. Disabling it is being too cautious.
-erik
On Monday, April 24, 2017, Einstein Toolkit < trac-noreply@einsteintoolkit.org> wrote:
#2031: Option to disable Piraha
----------------------+-----------------------------------------------------
Reporter: sbrandt | Owner: sbrandt Type: defect | Status: assigned Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords:
----------------------+-----------------------------------------------------
Changes (by sbrandt):
- owner: => sbrandt
- status: new => assigned
-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2031#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit _______________________________________________ Trac mailing list Trac@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/trac
Hello Erik, all,
I think the option should instead be to disable the old parser. The new parser already helped us find bugs in ccl files, and the new parser is the future. There is no known instance where the new parser silently have wrong results. Disabling it is being too cautious.
Right now it already is using the new parser.
I believe the intention during the call was rather that the option and help text would be there so that users who update Cactus, want to compile there (existing) code and get errors due to the parser, can at least revert to the old parser and get what they got before.
This may be either b/c we forgot to support a corner case or b/c their code relied on a specific behaviour of the old parser that no longer exists (or was simply buggy). This option would only exist for one release (think of it as the deprecation warning for parameters that will go away).
Yours, Roland
users@lists.einsteintoolkit.org
-
Erik Schnetter -
Roland Haas