I had the following lines in my thorn list:
# Private thorns !TARGET = $ARR !TYPE = ignore !CHECKOUT =
Note that the checkout item is empty. GetComponents reports two errors:
$ utils/Scripts/GetComponents --update --root=. manifest/einsteintoolkit.th Odd number of elements in hash assignment at utils/Scripts/GetComponents line 335. Use of uninitialized value in split at utils/Scripts/GetComponents line 441.
It should instead either report an error, or handle the case of a repository without thorns correctly.
-erik
# Private thorns !TARGET = $ARR !TYPE = ignore !CHECKOUT =
Note that the checkout item is empty. GetComponents reports two errors:
$ utils/Scripts/GetComponents --update --root=. manifest/einsteintoolkit.th Odd number of elements in hash assignment at utils/Scripts/GetComponents line 335. Use of uninitialized value in split at utils/Scripts/GetComponents line 441.
It should instead either report an error, or handle the case of a repository without thorns correctly.
You are right there should be better error tracking here. I think it should probably report the error and exit, there's no reason to have a section with an empty checkout.
Eric
On Jul 1, 2010, at 17:18 , Eric Seidel wrote:
# Private thorns !TARGET = $ARR !TYPE = ignore !CHECKOUT =
Note that the checkout item is empty. GetComponents reports two errors:
$ utils/Scripts/GetComponents --update --root=. manifest/einsteintoolkit.th Odd number of elements in hash assignment at utils/Scripts/GetComponents line 335. Use of uninitialized value in split at utils/Scripts/GetComponents line 441.
It should instead either report an error, or handle the case of a repository without thorns correctly.
You are right there should be better error tracking here. I think it should probably report the error and exit, there's no reason to have a section with an empty checkout.
It is useful to allow empty sections if one wants to quickly comments out a thorn for testing, without having to comment out the repository description as well:
# Various thorns from the AEI !TARGET = $ARR !TYPE = svn !URL = http://svn.aei.mpg.de/numrel/$1/$2/trunk !AUTH_URL = https://svn.aei.mpg.de/numrel/$1/$2/trunk !CHECKOUT = #AEIThorns/AEILocalInterp
-erik
users@lists.einsteintoolkit.org
-
Eric Seidel -
Erik Schnetter