Hello all,
Present were Steve, Peter, Erik, Zach, Joseph, Matt
* no objections to merging the rewrite branch of McLachlan - the last objection was Ian, who worried about performance. Performance is as good as before. The performance of McL dissipation is much faster. - there was some discussion about the completeness of tests, whether it was to roundoff and what sort of comparisons were done.
* no objections to reformatting some util thorns with clang-format, excepting thorn Accelerator.
* no objections to ticket #1786, which proposed switching to c99 inline semnatics. The ticket was moved to review_ok
Tickets #1794 Backport of mpi detect.pl changes #816 include SphericalHarmonicReconASCII from PITTNULLCode #1780 Correct name of Weinberg pseudotenser
are all in review_ok. Someone needs to apply them.
Cheers, Steve
Hello all,
#816 include SphericalHarmonicReconASCII from PITTNULLCode
Trying to apply it, I found issues and created ticket #1795
https://trac.einsteintoolkit.org/ticket/1795
which however is a ticket against PITTNull itself and not just the reader.
Yours, Roland
Hello all,
- no objections to reformatting some util thorns with clang-format,
excepting thorn Accelerator.
I think it may be good to add a file CODING_STYLE to document which clang-format options were used (and possibly which version). Ideally the file would provide a link to clang-format's homepage plus possibly instructions on how to integrate it into popular editors.
Yours, Roland
On Wed, Jul 22, 2015 at 08:32:31AM +0200, Roland Haas wrote:
I think it may be good to add a file CODING_STYLE to document which clang-format options were used (and possibly which version). Ideally the file would provide a link to clang-format's homepage plus possibly instructions on how to integrate it into popular editors.
Good idea. But if non-default coding styles were used, a file .clang-format in the thorn base dir should suffice for those. CODING_STYLE might still be useful to point to clang-format in the first place.
Frank
users@lists.einsteintoolkit.org
-
Frank Loeffler -
Roland Haas -
Steven R. Brandt