I reverted this commit because it broke Simfactory. It leads to errors such as
$ ./simfactory/bin/sim --remote nvidia execute date Traceback (most recent call last): File "./simfactory/bin/../lib/sim.py", line 148, in <module> main() File "./simfactory/bin/../lib/sim.py", line 141, in main RemoteExecute(remoteMachine) File "./simfactory/bin/../lib/sim.py", line 113, in RemoteExecute RemoteEnvironment.ExecuteSameCommand(parrotArguments=True, stripArguments=['remote', 'remotecactuspath', 'machine']) File "/Users/eschnett/Cvanilla/repos/simfactory2/lib/simremote.py", line 71, in ExecuteSameCommand remoteExe = self.GetRemoteExePath(localSourceBaseDir, sourceBaseDir) File "/Users/eschnett/Cvanilla/repos/simfactory2/lib/simremote.py", line 52, in GetRemoteExePath self.RemotePath = simlib.ReplaceLeadingPath(simenv.CACTUS_PATH, simlib.GetLocalSourceBaseDir(), remotes) AttributeError: 'module' object has no attribute 'ReplaceLeadingPath'
If you look at the code, it indeed seems there is no routine with the name "ReplaceLeadingPath".
I assume that's a small error that is easily corrected; in the mean time, I reverted this to ensure Simfactory remains usable.
-erik
---------- Forwarded message ---------- From: Bitbucket commits-noreply@bitbucket.org Date: Thu, Mar 10, 2016 at 9:19 PM Subject: commit/SimFactory2: eschnett: Revert "simremote: handle symbolic links in basedir gracefully" To: commits@cactuscode.org
1 new commit in SimFactory2:
https://bitbucket.org/simfactory/simfactory2/commits/2ed3398ecfe9/ Changeset: 2ed3398ecfe9 Branch: master User: eschnett Date: 2016-03-11 02:19:31+00:00 Summary: Revert "simremote: handle symbolic links in basedir gracefully"
This reverts commit f4407d48f500e6821218af8b6283e91826c52f7f.
Affected #: 1 file
Repository URL: https://bitbucket.org/simfactory/simfactory2/
--
This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email. _______________________________________________ Commits mailing list Commits@cactuscode.org http://cactuscode.org/mailman/listinfo/commits
Hello Erik,
I assume that's a small error that is easily corrected; in the mean time, I reverted this to ensure Simfactory remains usable.
Well kind of. There were some more issues with this attempt. The current one hopefully works better. At least I can do "sim --remote datura whoami" and "sim sync datura" from my workstation in various combinations involving symbolic links.
There is no test suite for simfactory, is there?
Yours, Roland
users@lists.einsteintoolkit.org