#1842: clang-format options not valid for versions <=3.5
--------------------+-------------------------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: unset | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
The current .clang-format file is not valid for clang-format versions 3.5
and below. The attached patch would 'fix' this by removing key words not
known in version 3.5, but still wouldn't work for versions below that. I
do not suggest to apply the patch - it should just show that this is quite
some number.
Looking at the .clang-format file it seems that it does not use one of the
pre-defined styles, but rather creates it's own (even if it is based on
one given the comment in the file). I wonder if all of this is really
necessary, or if we could not simply use one of the pre-defined styles,
possibly with a few changes that work across clang-format versions.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1842>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#584: Use of uninitialized value in concatenation
------------------------+---------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
After failing to check out a thornlist (the current einsteintoolkit.th)
the automated build and test system re-runs GetComponents with --update.
On 27-Sep-2011, this gave the error:
{{{
Use of uninitialized value in concatenation (.) or string at
./GetComponents line 2514.
}}}
This line seems to be
{{{
$url = "(".$component{"URL"}.")|(".$component{"AUTH_URL"}.")";
}}}
Is the problem that SimFactory doesn't have an AUTH_URL?
I'm attaching the log of the testsuite script. I don't know if the error
is serious or not, since the checkout has already failed.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/584>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1812: GetComponents needs to come with (a selected few) trusted certificates
---------------------------+------------------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: GetComponents | Version: development version
Keywords: |
---------------------------+------------------------------------------------
Most encrypted connections use some form of certificates. We use both ssl
for subversion and git. The problem with certificates is that the
certificate of the root CA has to be trusted by a client to be able to
form a trusted connection. Otherwise users get warnings, and either cannot
connect at all, or have to manually approve. We don't want both happening
with GetComponents.
Root CA certificates have to be changed from time to time. They have a
limited life time. In addition, there is a big movement away from SHA-1
certificates right now, as this has been found weak. The problem with that
is that an updated root CA might not have it made to all (or at least
most) clients at the time a user might have to trust it. Usually, root CAs
are created, but not actually used for some time for that reason. Security
problems like SHA-1 interfere with that. All this is nothing we can
change.
So, in the light of root CAs possibly faster changing than clients update
(and especially supercomputers update slowly in particular), we have to
have a mechanism to make GetComponents still work 'out of the box' with
these - no matter what the protocol is that actually uses it.
Right now, we only seem to have problems with svn, but in the future we
might have the same problem with git (bitbuckets root CA is still using
SHA-1).
For Subversion I propose the following. We ship 'too new' certificates
with GetComponents (in-source, to still have one file). We then write this
to a temporary file during checkout, and use the following option to svn
to get it to accept it:
{{{
--config-option servers:global:ssl-authority-files=<FILE>
}}}
This mechanism was tested manually on one of the problematic machines
(stampede), with one of the problematic certs (InCommon).
This only works for svn version 1.6 and newer. Most installations should
have that. In case we encounter an older one we could disable trusted cert
checking for problematic cases using --trust-server-cert.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1812>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1689: Cactus should exit with a nonzero exit code if an error occurs
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
In WarnLevel.c, in CCTK_VWarn (called by CCTK_Warn), it says
if (level <= error_level)
{
CCTK_Abort (NULL, 0);
}
The second argument to CCTK_Abort is the exit code of the process. So if
there is an "error" warning, the process exits with 0 exit code; i.e.
success! This happens in several places in this file.
The user guide does not say anything about the exit code of Cactus. I
think that if Cactus has a level-0 warning, i.e. an error, then it should
exit with a non-zero exit code, and Erik agrees.
See
http://lists.einsteintoolkit.org/pipermail/users/2014-November/003878.html
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1689>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1837: LocalInterp2 symmetry test fails on intel compiler machine
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: LocalInterp2 |
-----------------------------------+----------------------------------------
The intel compiler by default aggressively optimizes expressions, which
causes failures in the delicate cancellations required for LocalInterp2's
symmetry test.
The attached patch changes compiler options for the affected file only.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1837>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#702: Tests should use IO::out_fileinfo = "none"
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
The Cactus User Guide
(http://einsteintoolkit.org/documentation/UsersGuide/UsersGuidech9.html#x13-…)
recommends that test output files should always be the same, and hence use
IO::out_fileinfo = "none". I would like to implement this for the tests
in the ET, as it makes comparing test output using standard (non-Cactus
testsuite mechanism) diff tools possible.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/702>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1631: The dgfe branch for McLachlan generates NaNs
-----------------------------------------------------------+----------------
Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett
Type: defect | Status: new
Priority: optional | Milestone: ET_2014_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: dgfe,mclachlan,gamma driver |
-----------------------------------------------------------+----------------
When one uses the gamma driver formulation in the dgfe branch of McLachlan
and sets the shiftGammaCoefficient to zero, the runtime output has NaNs
because the code divides by zero.
A bit of flow control fixes this. Attached is a patch for the branch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1631>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1646: McLachlan does not give a reference for the gauge evolution equations
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: McLachlan |
-----------------------------------+----------------------------------------
McLachlan_BSSN.m does not seem to contain any information (eg in evolCalc)
that would tell me from which paper the different expressions for the
shift and lapse evolution expression are taken from (which may be useful
to understand what the different coefficients mean, since parsing the
multiple factors of the type XXXFactor * AAA + (1-XXXFactor) * BBB to get
either AAA or BBB is confusing).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1646>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1838: CactusUtils/WatchDog: is part of ET or not?
-----------------------------------+----------------------------------------
Reporter: bmundim | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: WatchDog |
-----------------------------------+----------------------------------------
if yes, then:
{{{
https://bitbucket.org/einsteintoolkit/manifest/pull-requests/6/add-
cactusutils-watchdog-to-the-thornlist/diff
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1838>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1840: ExternalLibraris/pthreads does not provide CCTK_PTHREADS define
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner: rhaas
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: pthreads |
-----------------------------------+----------------------------------------
This means it is not a drop in replacement for the old mechanism and eg
HTTPD complains at runtime with:
{{{
WARNING level 1 from host comet-ln3.sdsc.edu process 0
while executing schedule bin HTTP_Startup, routine
HTTPD::HTTP_StartServer
in thorn HTTPD, file
/home/rhaas/cactus/ET_trunk/arrangements/CactusConnect/HTTPD/src/Startup.c:97:
-> Parameter 'HTTPD::use_pthreads' is set to "yes" but you didn't
configure with PTHREADS. Setting will be ignored.
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1840>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit