#1931: provide CCTK_FullName like function whose returned string does not have to
be free'd
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
{{{CCTK_FullName}}} differs from {{{CCTK_VarName}}} in that its returned
string must be freed by the caller which is often tedious. Since there is
no real reason for this, the pull request at
https://bitbucket.org/cactuscode/cactus/pull-requests/27/provide-
cctk_fullname-like-function-whose/diff provides a more convenient function
{{{CCTK_FullVarName}}} which returns a pointer to a flesh managed storage
area with the full variable name (exactly paralleling {{{CCTK_VarName}}}).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1931>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1881: Unclear error message for parameter file error
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
I had this line in a parameter file
{{{
ML_BSSN_FH_Helper::ML_BSSN_FH_CalculateRHSInMoLPostStep
}}}
which is missing the {{{= yes}}} at the end. This is a syntax error.
I receive the following error message:
{{{
^[[1mWARNING level 0 from host zwicky002 process 0
while executing schedule bin (none), routine (no thorn)::(no routine)
in thorn cactus, file mk-mclachlan-funhpc.par:1:
->^[[0m ERROR IN PARAMETER FILE:In rule 'file::set' Line=100, Column=95
# ML_BSSN_FH::block_size_i = 4
# ML_BSSN_FH::block_size_j = 4
# ML_BSSN_FH::block_size_k = 4
ML_BSSN_FH::ML_log_confac_bound = "none"
^
Expected one of the following characters: [\[ \t\r\n#=]
}}}
This error message is unclear because
- it doesn't show the line that has the error; instead, it show only the
lines that follow (and that are correct)
- the set of "following characters" is correct, but I got confused by all
the white space characters that are allowed; a description "expected [ or
=" might have been more clear
- the actual error is that there is a parameter, but this parameter is not
followed by a value; this is not described, since the error message has a
rather low level ("next character") instead of a high level ("value
missing")
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1881>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1697: testing system starts tests for which thorns are missing
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
We apparently have a bug in the perl script that drives the testsuite. On
hydra (a machine at RZG that Ian and I are testing) it tries to run the
test_ah test of Dissipation even though that test parfile uses NoExcision
which is commented out.
A quick test indicates that the script only looks at the first
ActiveThorns line in the parfile when it determines if a parfile is
runnable. Movin NoExcision into the first ActiveThorns line correctly
ignores the test on hydra.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1697>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1623: using ENV in parfiles is not documented
---------------------------+------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: documentation |
---------------------------+------------------------------------------------
the user guide does not explain how to use ENV in parfiles (at least grep
ENV doc/UsersGuide/*.tex does not find anything) nor do the peg files in
src/piraha/peg contain.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1623>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1930: GRHydro_InitData -> HydroBase_InitData?
--------------------------------+-------------------------------------------
Reporter: zachetie@… | Owner:
Type: enhancement | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
--------------------------------+-------------------------------------------
GRHydro_InitData seems to clash with the modern ET approach of making
initial data thorns link only to HydroBase/ADMBase (i.e., being evolution-
code agnostic), so that any evolution code may take advantage of the
functionality.
With slight modifications (possibly requiring the creation of a simple
GRHydro compatibility layer thorn, a la "ID_converter_ILGRMHD"), this
thorn could be made useful to all HydroBase-compatible GRMHD codes.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1930>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1929: Make unused/redundant gridfunction storage optional in HydroBase
--------------------------------+-------------------------------------------
Reporter: zachetie@… | Owner:
Type: defect | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
--------------------------------+-------------------------------------------
The w_lorentz & eps gridfunctions are always stored in HydroBase, despite
the first being redundant and the second unused (in IllinoisGRMHD, at
least).
Storage for these should be optional; I would suggest enabling storage of
these gridfunctions by default (current behavior, won't break anything)
but allowing the storage to be disabled.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1929>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1862: Patch: make Refluxing infrastructure independent of GRHydro
-----------------------------------+----------------------------------------
Reporter: dradice@… | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
GRHydro can optionally run with conservative AMR using the "Refluxing"
thorn. The infrastructure for refluxing is very generic, but the
"Refluxing" thorn currently contains GRHydro-specific code that makes it
incompatible with any other solver.
To overcome this limitation, I prepared:
1. A patched version of the Refluxing thorn, with a generic MoL-like
registration mechanism for the fluxes
2. A new thorn containing all of the old GRHydro-specific code from
Refluxing.
The new code passes all existing tests and allow other (M)HD thorns to
register variables for refluxing in a very simple way. The code is in two
git repositories on bitbucket:
https://bitbucket.org/dradice/refluxinghttps://bitbucket.org/dradice/grhydro_refluxing
Notes:
1. GRHydro parfiles that use conservative AMR should be modified to
include GRHydro_Refluxing
2. The new Refluxing thorn no longer supports delayed refluxing, which was
never used for any production run, and/or special GRHydro-specific
atmosphere hacks.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1862>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1921: Broken McLachlan link on ET "Citing" page.
-------------------------------------+--------------------------------------
Reporter: bentivegna | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit website | Version: development version
Keywords: |
-------------------------------------+--------------------------------------
At the bottom of this page, the "McLachlan, a public BSSN code" link
points (at least on Mac OS, Firefox) to:
http://www.cct.lsu.edu/%C2%A0eschnett/McLachlan/
The actual URL should be:
https://www.cct.lsu.edu/~eschnett/McLachlan/
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1921>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1925: poisson equation image in gallery is too big
----------------------------+-----------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus website | Version: development version
Keywords: |
----------------------------+-----------------------------------------------
The image for the poisson equation example in the gallery
http://einsteintoolkit.org/about/gallery/ shows up too big for me, it
shows up with 1322 pixels for me and is much wider than any of the other
images. I would suggest to tie its width to the width of the window and
use something like 80% for the width attribute.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1925>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit