Trac March 2023

trac@lists.einsteintoolkit.org

1 participants
130 discussions

#2692: Inclusion of FUKA importer thorns
by Roland Haas 23 Mar '23

23 Mar '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): With the inclusion progressing, would it be possible to add push hooks so that commit emails are sent to the ET commits mailing list? See here: [https://docs.einsteintoolkit.org/et-docs/Services#git](https://docs.einstei… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2692: Inclusion of FUKA importer thorns
by Roland Haas 23 Mar '23

23 Mar '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): That still leaves point \(b\). Note that _if_ `kadath_pizza` \(2 typos actually, “F != f” and “katathpizza != kadath\_pizza”\) is included then, to match what is done for the other `DISABLED` thorns \(which can be enabled using simfactory’s `enable-thorn` machine ini option\) then `kadath_pizza` should show up in the `!CHECKOUT` line so that GetComponents checks it out, but Cactus does not use it. See eg ReprimAnd. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2692: Inclusion of FUKA importer thorns
by tootle 23 Mar '23

23 Mar '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by tootle): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} No issue with removal. As an FYI for those they may be interested, this is simply a typo and the line should read: `#DISABLED Fuka/kadath_pizza # Only for use with WhiskyTHC + PizzaBase` -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2692: Inclusion of FUKA importer thorns
by Roland Haas 23 Mar '23

23 Mar '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): The current thornlist contains: ``` #DISABLED fuka/kadathpizza # Only for use with WhiskyTHC + PizzaBase ``` but \(a\) [https://bitbucket.org/fukaws/kadathpizza](https://bitbucket.org/fukaws/kada… is private \(I get a 404 error trying to access\) \(b\) Pizza is not part of the eT \(c\) capitalization matters, `fuka` and `Fuka` are different arrangements I would suggest to remove the line from the thornlist \(GetComponents will fail with a failed download\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Roland Haas 22 Mar '23

22 Mar '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): uh, not quite sure I follow. For the ET owned repo’s branch \(I guess manifest is the repo\) branching off of master is preferred. The reason being that “master” is the branch that actually gets tested on the cluster and that people who want the bleeding edge code download. For branches in Canuda’s home org: your choice really. As long as the master branch of `einsteintoolkit/manifest/einsteintoolkit.th` points to the the proposed branch in Canuda \(after the does no harm\) then this is fine \(eg a couple contributions use “main” instead of “master”\). There is a slight advantage if the proposed branch is the default branch since that is the one GetComponents will chose if not branch name is given \(and the vanilla “development” thornlist has no `REPO_BRANCH` statements\). But that is very minor and really only exploitable if the default branch is the branch development happens on \(and not eg the last stable release one\). Note for release manager: having `REPO_BRANCH` in the development thornlist will likely require some changes to the scripts \(and script fragments\) used to create the release thornlist \(since it assumes that it can just add `REPO_BRANCH` and does not have to modify existing `REPO_BRANCH` statements\). The branch name in outside repos is not under control anyway and with GitHub advertising against “master” there is a proliferation anyway \(“main”, “devel”, “development” seem to be popular\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Samuel Cupp 22 Mar '23

22 Mar '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Samuel Cupp): That should be ok, but I’d like a maintainer to weigh in. When we make the ET\_2023\_05 branch, we would just have to branch it off of that instead of master. @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} @{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} any issues with this? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Cheng-Hsin Cheng 22 Mar '23

22 Mar '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Cheng-Hsin Cheng): Yes, I will remove NPScalars\_SF from the PR on the manifest. About the REPO\_BRANCH, is it possible for us to use a separate branch from master for our proposal for the next release? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Samuel Cupp 22 Mar '23

22 Mar '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Samuel Cupp): Ok. Thank you for the update. If you don’t mind, can you also update the PR on the manifest? I believe there are also some commits to merge in as well. If you are ready, you can also merge TwoPunctures\_BBHSF into master and remove the REPO\_BRANCH line from the PR. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Cheng-Hsin Cheng 22 Mar '23

22 Mar '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Cheng-Hsin Cheng): @{557058:088051f9-5b94-4b5e-bfbe-71137030b9c1} @{557058:f7fd5133-6eee-4385-a5e5-3e03342a0b24} Apologies for the lack of updates on NPScalars\_SF. But Helvi and Giuseppe and I were only discussing today about withdrawing it from inclusion into the next ETK release, and instead to update the original NPScalars thorn in the future to support other matter terms including scalar fields. From what I understand, Miguel thinks this would be a better decision for the code too. So we would like to retract NPScalars\_SF from the next release, and Peter is off the hook from reviewing it. Dropping NPScalars\_SF will affect the parameter files in TwoPunctures\_BBHSF which are using it, so we will also update the parameter files there to use the original NPScalars. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

#2697: Include BBH+scalar field initial data code from Canuda in ET
by Samuel Cupp 22 Mar '23

22 Mar '23

#2697: Include BBH+scalar field initial data code from Canuda in ET Reporter: Cheng-Hsin Cheng Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Samuel Cupp): Leo and I had already received an email regarding TwoPunctures\_BBHSF, but @{5a39478ed96dcc384266ff71} has finished his review, so all that remains is completing the review for NPScalars\_SF. Whenever @{557058:f7fd5133-6eee-4385-a5e5-3e03342a0b24} has an update, please let us know. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
13
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac March 2023