#2741: Some thorns seem to incorrectly use CCTK_GFINDEX4D
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Gabriele Bozzola):
Let me double check what version we are running, maybe it was fixed and I rushed into reporting it!
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2741/some-thorns-seem-…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Leonardo Werneck):
Hi @{712020:6db3039f-ec91-4049-9d17-ea10007f7722} ! Would it be possible for you to share a parameter file that results in this error?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2741: Some thorns seem to incorrectly use CCTK_GFINDEX4D
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
status: open (was new)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2741/some-thorns-seem-…
#2741: Some thorns seem to incorrectly use CCTK_GFINDEX4D
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Still? Grr. I though tthat had been fixed in #2582 but clearly this was missed and also missed in #2394.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2741/some-thorns-seem-…
#2741: Some thorns seem to incorrectly use CCTK_GFINDEX4D
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
A student in my group found the following problem in `ID_converter_ILGRMHD`:
If you compile Einstein Toolkit in debug mode, the code crashes. This is due to the function `CCTK_GFINDEX4D` that is used in some thorns \(such as `ID_converter_ILGRMHD`\). The function is used to unroll a vector index into a linear one:
```c
int CCTK_GFIndex4D (const cGH *GH, int i, int j, int k, int l)
{
#ifdef CCTK_DEBUG
if (i < 0 || i >= GH->cctk_lsh[0] ||
j < 0 || j >= GH->cctk_lsh[1] ||
k < 0 || k >= GH->cctk_lsh[2] ||
l < 0 || l >= GH->cctk_lsh[3])
{
CCTK_VError (__LINE__, __FILE__, "Cactus",
"Grid function index out of bounds. i=%d j=%d k=%d l=%d cctk_lsh=[%d,%d,%d,%d]",
i, j, k, l, GH->cctk_lsh[0], GH->cctk_lsh[1], GH->cctk_lsh[2], GH->cctk_lsh[3]);
}
#endif
return (i + GH->cctk_ash[0]*(j + GH->cctk_ash[1]*(k + GH->cctk_ash[2] * l)));
}
```
The code crashes when `CCTK_DEBUG` because cctk\_lsh\[3\] is 0, so the conditional in line 7 is not satisfied.
To reproduce, run `magnetizedTOV.par `in IllinoisGRMHD with `CCTK_DEBUG` enabled.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2741/some-thorns-seem-…
#2740: broken links in the Tutorial for New Users webpage
Reporter: Bruno Giacomazzo
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit website
Comment (by Bruno Giacomazzo):
Thanks Roland, I confirm they work now also for me.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2740/broken-links-in-t…
#2740: broken links in the Tutorial for New Users webpage
Reporter: Bruno Giacomazzo
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit website
Changes (by Roland Haas):
responsible: [] (was )
assignee: Roland Haas (was )
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2740/broken-links-in-t…
#2740: broken links in the Tutorial for New Users webpage
Reporter: Bruno Giacomazzo
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit website
Comment (by Roland Haas):
Hello Bruno. Thanks for letting us know. Turns out I had forgotten to make the repository “public” when moving it from the nds-org owned repository to an EinsteinToolkit owned one. Naturally, the private repo does work for me. Should be fixed now.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2740/broken-links-in-t…